Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1987108: vSpehere: disable vmxnet3 tx csum offload #2734

Merged
merged 1 commit into from Aug 26, 2021

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Aug 26, 2021

- What I did
Disable tx checksum offload of vmxnet3 interfaces.

- How to verify it
On VSphere openshift cluster HW >= 14, verify cluster up with normal operation and check tx-checksum-ip-generic is off with ethtool -k <vmxnet3 dev> on cluster nodes.

- Description for the changelog
Disable tx checksum offload of vmxnet3 interfaces.

Closes: #1987108
Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jcaamano: This pull request references Bugzilla bug 1980135, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1980135: configure-ovs: set tx checksum offload off vmxnet3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 26, 2021
@jcaamano jcaamano changed the title Bug 1980135: configure-ovs: set tx checksum offload off vmxnet3 Bug 1987108: configure-ovs: set tx checksum offload off vmxnet3 Aug 26, 2021
@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jcaamano: This pull request references Bugzilla bug 1987108, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1987108: configure-ovs: set tx checksum offload off vmxnet3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jcaamano: This pull request references Bugzilla bug 1987108, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1987108: configure-ovs: set tx checksum offload off vmxnet3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6

@jupierce jupierce self-requested a review August 26, 2021 13:41
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@jcaamano jcaamano changed the title Bug 1987108: configure-ovs: set tx checksum offload off vmxnet3 Bug 1987108: vSpehere: disable vmxnet3 tx csum offload Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jcaamano: This pull request references Bugzilla bug 1987108, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1987108: vSpehere: disable vmxnet3 tx csum offload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@jcaamano
Copy link
Contributor Author

/test e2e-gcp-upgrade
/test e2e-aws-upgrade

@jcaamano
Copy link
Contributor Author

/test e2e-vsphere-upgrade

@jcaamano
Copy link
Contributor Author

/test e2e-vsphere
/test e2e-vsphere-upi

@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jcaamano, jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikaslaad
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Aug 26, 2021

/refresh

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade da59886 link /test e2e-gcp-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack 1ef1d7bf3b94fb04484bfe50fd77bc77884475b4 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-single-node da59886 link /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel7 da59886 link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-disruptive da59886 link /test e2e-aws-disruptive
ci/prow/e2e-aws-upgrade-single-node da59886 link /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-upgrade da59886 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Aug 26, 2021

Waiting to see what e2e-upgrade-agnostic comes back with and then going to kick these in.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Aug 26, 2021

/override ci/prow/e2e-agnostic-upgrade
Pass rate on this lately is horrible.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-agnostic-upgrade

In response to this:

/override ci/prow/e2e-agnostic-upgrade
Pass rate on this lately is horrible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit fa42f1e into openshift:master Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jcaamano: All pull requests linked via external trackers have merged:

Bugzilla bug 1987108 has been moved to the MODIFIED state.

In response to this:

Bug 1987108: vSpehere: disable vmxnet3 tx csum offload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants