[release-4.7] Bug 2008692: Don't write empty static pod manifests #2783

cybertron · 2021-09-28T21:07:51Z

Kubelet complains about empty files in the manifests directory because
it can't parse them. While this doesn't cause any harm, it has caused
bugs to be mis-routed because people see the error messages while
debugging and think something is wrong.

Instead of conditionalizing the content of the files, we can
conditionalize the path and just write them to a disabled location
so they won't be deployed and they also won't be processed by kubelet.
Note that I tried just using /dev/null to avoid writing the files
entirely, but I was not able to get that to work.

- What I did

- How to verify it

- Description for the changelog

Kubelet complains about empty files in the manifests directory because it can't parse them. While this doesn't cause any harm, it has caused bugs to be mis-routed because people see the error messages while debugging and think something is wrong. Instead of conditionalizing the content of the files, we can conditionalize the path and just write them to a disabled location so they won't be deployed and they also won't be processed by kubelet. Note that I tried just using /dev/null to avoid writing the files entirely, but I was not able to get that to work.

openshift-ci · 2021-09-28T21:07:58Z

@cybertron: This pull request references Bugzilla bug 2008692, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1927042 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1927042 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vvoronko@redhat.com), skipping review request.

In response to this:

[release-4.7] Bug 2008692: Don't write empty static pod manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-29T02:08:03Z

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-assisted	`e80a24c`	link	false	`/test e2e-metal-assisted`
ci/prow/e2e-vsphere-upgrade	`e80a24c`	link	false	`/test e2e-vsphere-upgrade`
ci/prow/e2e-ovn-step-registry	`e80a24c`	link	false	`/test e2e-ovn-step-registry`
ci/prow/e2e-aws-serial	`e80a24c`	link	false	`/test e2e-aws-serial`
ci/prow/okd-e2e-gcp-op	`e80a24c`	link	false	`/test okd-e2e-gcp-op`
ci/prow/okd-e2e-upgrade	`e80a24c`	link	false	`/test okd-e2e-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre

/lgtm

cybertron · 2021-10-04T18:00:31Z

/test e2e-vsphere-upi

This is the test that is most affected by this change.

kikisdeliveryservice · 2021-10-04T22:37:06Z

Original fix PR (since this couldn't be auto-cherrypicked): #2413

kikisdeliveryservice · 2021-10-04T22:37:51Z

@cybertron is this good now? vsphere upi test passed.

cybertron · 2021-10-05T16:01:48Z

@kikisdeliveryservice Thanks for linking the original PR. I didn't think to do that when I pushed this.

With the upi job passing we should be good to merge this.

openshift-ci · 2021-10-05T17:22:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, kikisdeliveryservice, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-10-05T17:34:45Z

/retest-required