Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2013164: [IPI ON-PREM] move Keepalived default ingress script to separate file #2798

Merged
merged 1 commit into from Oct 21, 2021
Merged

[release-4.9] Bug 2013164: [IPI ON-PREM] move Keepalived default ingress script to separate file #2798

merged 1 commit into from Oct 21, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2761

/assign yboaron

@yboaron
move Keepalived default ingress script to separate file
6d675b0 
The Keepalived default ingress track script checks if a node running an instance of a default router pod.
We noticed that Keepalived failed to run this script as a command, this PR moves default ingress track script
to a separate file (like chk_ocp_lb and chk_ocp_both).
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 12, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@openshift-cherrypick-robot: Bugzilla bug 2003655 has been cloned as Bugzilla bug 2013164. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2013164: [IPI ON-PREM] move Keepalived default ingress script to separate file

In response to this:

[release-4.9] Bug 2003655: [IPI ON-PREM] move Keepalived default ingress script to separate file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2003655: [IPI ON-PREM] move Keepalived default ingress script to separate file [release-4.9] Bug 2013164: [IPI ON-PREM] move Keepalived default ingress script to separate file Oct 12, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2013164, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2003655 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2003655 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vvoronko@redhat.com), skipping review request.

In response to this:

[release-4.9] Bug 2013164: [IPI ON-PREM] move Keepalived default ingress script to separate file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor

yboaron commented Oct 12, 2021

test e2e-openstack
/test e2e-vsphere
/test e2e-ovirt

mandre
mandre reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@kikisdeliveryservice
Copy link
Contributor

/test e2e-vsphere
/test e2e-vsphere-upgrade

@yboaron
Copy link
Contributor

yboaron commented Oct 13, 2021

/test e2e-vsphere

@cybertron
Copy link
Member

/retest-required
/lgtm

@yboaron
Copy link
Contributor

yboaron commented Oct 15, 2021

/test e2e-vsphere
/retest-required

@yboaron
Copy link
Contributor

yboaron commented Oct 17, 2021

CI is green for all the relevant platforms, I think we can merge this backport PR

@kikisdeliveryservice
Copy link
Contributor

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, kikisdeliveryservice, mandre, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@kikisdeliveryservice
Copy link
Contributor

/backport-risk-assessed

@kikisdeliveryservice kikisdeliveryservice added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 18, 2021
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 21, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2021 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp-op 6d675b0 link false /test okd-e2e-gcp-op
ci/prow/okd-e2e-aws 6d675b0 link false /test okd-e2e-aws
ci/prow/e2e-aws-techpreview-featuregate 6d675b0 link false /test e2e-aws-techpreview-featuregate
ci/prow/e2e-aws-upgrade-single-node 6d675b0 link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-serial 6d675b0 link false /test e2e-aws-serial
ci/prow/e2e-aws-workers-rhel7 6d675b0 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-disruptive 6d675b0 link false /test e2e-aws-disruptive
ci/prow/okd-e2e-upgrade 6d675b0 link false /test okd-e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2a7b231 into openshift:release-4.9 Oct 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2013164 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2013164: [IPI ON-PREM] move Keepalived default ingress script to separate file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor

yboaron commented Nov 2, 2021

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Author

@yboaron: #2798 failed to apply on top of branch "release-4.8":

Applying: move Keepalived default ingress script to separate file
Using index info to reconstruct a base tree...
M	templates/master/00-master/on-prem/files/keepalived-keepalived.yaml
M	templates/worker/00-worker/on-prem/files/keepalived-keepalived.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/worker/00-worker/on-prem/files/keepalived-keepalived.yaml
CONFLICT (content): Merge conflict in templates/worker/00-worker/on-prem/files/keepalived-keepalived.yaml
Auto-merging templates/master/00-master/on-prem/files/keepalived-keepalived.yaml
CONFLICT (content): Merge conflict in templates/master/00-master/on-prem/files/keepalived-keepalived.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 move Keepalived default ingress script to separate file
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor

yboaron commented Nov 8, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 8, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

@yboaron: new pull request created: #2825

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron yboaron mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

@EmilienM EmilienM Awaiting requested review from EmilienM

@hardys hardys Awaiting requested review from hardys

Assignees

@mandre mandre

@cybertron cybertron

@yboaron yboaron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @yboaron @kikisdeliveryservice @cybertron @openshift-bot @mandre @mrunalp @openshift-merge-robot