Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2033729: Remove runtime request timeout restriction and add azure config #2883

Conversation

rphillips
Copy link
Contributor

  • Removes the restriction of setting the runtimeRequestTimeout within the kubelet config.
  • Adds an azure specific config to bump the runtimeRequestTimeout to 4m

@rphillips rphillips changed the title Remove container request timeout restriction Remove container request timeout restriction and add azure config Dec 17, 2021
@dgoodwin
Copy link
Contributor

Thank you! lgtm but will let MCO folks tag.

@rphillips
Copy link
Contributor Author

/test e2e-azure
/test e2e-azure-upgrade

Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this change mainly effect azure platform
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rphillips rphillips changed the title Remove container request timeout restriction and add azure config Remove runtime request timeout restriction and add azure config Dec 17, 2021
@rphillips rphillips changed the title Remove runtime request timeout restriction and add azure config Bug 2033729: Remove runtime request timeout restriction and add azure config Dec 17, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@rphillips: This pull request references Bugzilla bug 2033729, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

Bug 2033729: Remove runtime request timeout restriction and add azure config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@rphillips
Copy link
Contributor Author

/test e2e-agnostic-upgrade

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2021

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 89e7dc9 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-workers-rhel7 89e7dc9 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-ovn-step-registry 89e7dc9 link false /test e2e-ovn-step-registry
ci/prow/e2e-vsphere-upgrade 89e7dc9 link false /test e2e-vsphere-upgrade
ci/prow/e2e-aws-workers-rhel8 89e7dc9 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-metal-ipi 89e7dc9 link false /test e2e-metal-ipi
ci/prow/e2e-aws-upgrade-single-node 89e7dc9 link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-single-node 89e7dc9 link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0dd132c into openshift:master Dec 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2021

@rphillips: All pull requests linked via external trackers have merged:

Bugzilla bug 2033729 has been moved to the MODIFIED state.

In response to this:

Bug 2033729: Remove runtime request timeout restriction and add azure config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@umohnani8
Copy link
Contributor

Can this be backported to 4.8 as well? Only the change to remove the restriction around setting the runtime request timeout. We are seeing some issues with timeouts so would like to increase this to see if it helps mitigate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants