Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Christoph as a baremetal owner #2920

Merged
merged 1 commit into from Jan 28, 2022

Conversation

cybertron
Copy link
Member

He's been working on metal IPI for a while now so he should be in the
list. I also removed Yossi from the reviewer list since he recently
moved to a different team. I'm leaving him as an approver for now
since we might still want to pull him in on patches. We just don't
want to pester him with automatic review requests.

He's been working on metal IPI for a while now so he should be in the
list. I also removed Yossi from the reviewer list since he recently
moved to a different team. I'm leaving him as an approver for now
since we might still want to pull him in on patches. We just don't
want to pester him with automatic review requests.
@cybertron
Copy link
Member Author

/cc @creydr

@openshift-ci openshift-ci bot requested a review from creydr January 20, 2022 17:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@cybertron: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creydr can you lgtm this?

:)

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@creydr
Copy link
Member

creydr commented Jan 21, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, cybertron, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link
Contributor

@cybertron can this wait until after freeze?

@cybertron
Copy link
Member Author

Yeah, that should be fine. The hassle of opening a bz to merge this would likely be more than the hassle of not having Christoph in the list for another week. :-)

@openshift-merge-robot openshift-merge-robot merged commit 3a91cb2 into openshift:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants