New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Christoph as a baremetal owner #2920
Add Christoph as a baremetal owner #2920
Conversation
He's been working on metal IPI for a while now so he should be in the list. I also removed Yossi from the reviewer list since he recently moved to a different team. I'm leaving him as an approver for now since we might still want to pull him in on patches. We just don't want to pester him with automatic review requests.
/cc @creydr |
@cybertron: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@creydr can you lgtm this?
:)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, cybertron, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cybertron can this wait until after freeze? |
Yeah, that should be fine. The hassle of opening a bz to merge this would likely be more than the hassle of not having Christoph in the list for another week. :-) |
He's been working on metal IPI for a while now so he should be in the
list. I also removed Yossi from the reviewer list since he recently
moved to a different team. I'm leaving him as an approver for now
since we might still want to pull him in on patches. We just don't
want to pester him with automatic review requests.