daemon: bootimage and ignition logging #2994
Conversation
|
(only compile tested locally) |
openshift-ci
bot
added
the
approved
cgwalters
force-pushed
the
log-ignition-provisioning
branch
3 times, most recently
from
3d72716
to
ceaa278
Compare
|
Yep, looks good, see e.g. this log: |
pkg/daemon/coreos.go
Outdated
| if err := json.Unmarshal(contents, &ignProvisioning); err != nil { | ||
| return err | ||
| } | ||
| fmt.Printf("Ignition provisioning: time=%v\n", ignProvisioning.ProvisioningDate) |
There was a problem hiding this comment.
is there are reason to not use glog here?
My immediate motivation is to gather more information in the MCD logs; same reason we log the boots. For coreos layering work, we will be sensitive to the initial bootimage more and may need to update it. Another angle for this is that we could actually plumb this information up into the node object, and from there into the operator/controller and feed it into prometheus and into telemetry, so we start to gather information on e.g. how many clusters have old bootimages. Also log Ignition provisioning information.
cgwalters
force-pushed
the
log-ignition-provisioning
branch
from
ceaa278
to
a7f99eb
Compare
|
I originally had a two-commit series but accidentally squashed fixes into the second; at this point disentangling that isn't worth it, so just squashed to one commit. |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
daemon: Log data from
/sysroot/.coreos-aleph-version.jsonMy immediate motivation is to gather more information in the MCD
logs; same reason we log the boots. For coreos layering work,
we will be sensitive to the initial bootimage more and may need
to update it.
Another angle for this is that we could actually plumb this information
up into the node object, and from there into the operator/controller
and feed it into prometheus and into telemetry, so we start
to gather information on e.g. how many clusters have old bootimages.
daemon: Also log Ignition provisioning information
More data is good here; this builds on the previous information
for the bootimage generation time.