[release-4.9] Bug 2089763: configure-ovs: persist profiles after auto-connect has been set #3183
Conversation
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
openshift-ci
bot
added
bugzilla/severity-urgent
|
@jcaamano: This pull request references Bugzilla bug 2089763, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcaamano: This pull request references Bugzilla bug 2089763, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
requested review from
rbbratta,
kikisdeliveryservice and
sinnykumari
|
/test 4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade |
|
/test e2e-aws-ovn-workers-rhel8 |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/assign @andreaskaris |
| copy_nm_conn_files "$NM_CONN_UNDERLAY" | ||
| if [ -f "$extra_bridge_file" ]; then |
There was a problem hiding this comment.
/lgtm
I had a doubt about how bash behaves and if $extra_bridge_file would be available here given that the variable is defined way below but it clearly works:
1 #!/bin/bash
2
3 function test_function {
4 echo "Foo is: $foo"
5 }
6
7 foo=bla
8 test_function
[akaris@linux ~]$ bash -x test.sh
+ foo=bla
+ test_function
+ echo 'Foo is: bla'
Foo is: bla
|
/lgtm |
|
/test e2e-aws-workers-rhel8 |
|
/assign @sinnykumari |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreaskaris, jcaamano, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sinnykumari
added
the
backport-risk-assessed
|
Needs cherry-pick-approved label |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@jcaamano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jcaamano: All pull requests linked via external trackers have merged: Bugzilla bug 2089763 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After backporting 715393a in #3160, auto-connect was being set after keyfiles were persisted from the overlay
systemConnectionsMergedto the underlaysystem-connectionsand thus the setting was lost after reboot. So persist profiles at the very end.Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com
- What I did
- How to verify it
- Description for the changelog