Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] OCPBUGS-420: Fix problem with retaining data in string array in piped while loop #3300

Merged
merged 1 commit into from Aug 30, 2022
Merged

[release-4.9] OCPBUGS-420: Fix problem with retaining data in string array in piped while loop #3300

merged 1 commit into from Aug 30, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3289

/assign jcaamano

@arkadeepsen
Fix problem with retaining data in string array in piped while loop
068044a 
Data added to string array in piped while loop is not retained after the loop. Process substitution (http://mywiki.wooledge.org/ProcessSubstitution) fixes the probelm.

Signed-off-by: Arkadeep Sen <arsen@redhat.com>
(cherry picked from commit 7617323)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 22, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2118609 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 401 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] Bug 2118609: Fix problem with retaining data in string array in piped while loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor

jcaamano commented Aug 22, 2022 •
edited by openshift-ci bot

/retitle [release-4.9] OCPBUGS-420: Fix problem with retaining data in string array in piped while loop

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2118609: Fix problem with retaining data in string array in piped while loop [release-4.9] OCPBUGS-420: Fix problem with retaining data in string array in piped while loop Aug 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022 •
edited

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.9] OCPBUGS-420: Fix problem with retaining data in string array in piped while loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2022 •
edited by openshift-ci bot

@openshift-cherrypick-robot: This pull request references [Jira Issue OCPBUGS-420](https://issues.redhat.com//browse/OCPBUGS-420), which is invalid:

  • expected dependent Jira Issue OCPBUGS-419 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #3289

/assign jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 22, 2022
@jcaamano
Copy link
Contributor

/test 4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade
/test e2e-aws-ovn-workers-rhel8
/test e2e-azure-ovn-upgrade
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6

@jcaamano
Copy link
Contributor

/label backport-risk-assessed

@jcaamano
Copy link
Contributor

/assign @arkadeepsen

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 23, 2022
@sinnykumari
Copy link
Contributor

clean backport
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@arkadeepsen
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkadeepsen, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaamano
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jcaamano: This pull request references Jira Issue OCPBUGS-420, which is invalid:

  • expected Jira Issue OCPBUGS-420 to depend on a bug targeting a version in 4.10.0, 4.10.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

Added OCPBUGS-419 to depend in the Jira card, should be good now
/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 29, 2022
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Jira Issue OCPBUGS-420, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-419 is in the state Verified (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE))
  • dependent Jira Issue OCPBUGS-419 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Added OCPBUGS-419 to depend in the Jira card, should be good now
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2022 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 068044a link false /test e2e-aws-serial
ci/prow/e2e-aws-disruptive 068044a link false /test e2e-aws-disruptive
ci/prow/okd-e2e-aws 068044a link false /test okd-e2e-aws
ci/prow/4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade 068044a link false /test 4.9-upgrade-from-stable-4.8-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-upgrade 068044a link false /test okd-e2e-upgrade
ci/prow/okd-e2e-gcp-op 068044a link false /test okd-e2e-gcp-op
ci/prow/e2e-aws-upgrade-single-node 068044a link false /test e2e-aws-upgrade-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD efc563c and 8 for PR HEAD 068044a in total

@openshift-merge-robot openshift-merge-robot merged commit 72c1bb1 into openshift:release-4.9 Aug 30, 2022
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-420 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3289

/assign jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano jcaamano mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@arkadeepsen arkadeepsen

@jcaamano jcaamano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @jcaamano @openshift-ci-robot @sinnykumari @arkadeepsen @anuragthehatter @openshift-merge-robot