New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump openshift/api #3336
Bump openshift/api #3336
Conversation
The current api bump is being performed via #3269 Let's rebase on that as necessary /hold |
openshift/api bump has been done with PR #3269 merged. If you still need further api bump, please rebase this PR on top of master to get required changes |
203f48f
to
a4e7b6b
Compare
4a00870
to
3dd5339
Compare
@yuqi-zhang I am not sure what to do with that failing |
@yuqi-zhang passed |
The previous version was erroring on Go v1.18
112f7cb
to
80e1050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry I didn't get to this earlier. It looks like the kubevirt platform type was updated, namely this:
https://github.com/openshift/machine-config-operator/blob/master/pkg/controller/template/render_test.go#L86
Should be external
now, and it should pass
Otherwise, generally seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the PR
Since #3269 has been merged, hold is not needed |
hmm, the status is outdated, just to check /test bootstrap-unit |
@pierreprinetti: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Ok, looks like unit tests are good now. Do you expect this to affect any specific platform? Should we run some additional tests (e.g. payload tests) to make sure? And also to check, we expect e2e-openstack to fail right? |
All OpenStack CI 4.12 tests are failing at the moment unfortunately.
I am asking for this bump because I need to test an MCO patch against a PR of openshift/api that is based on a recent commit of openshift/api, and I am trying to avoid conflicts. We will need to bump again openshift/api in MCO when the work is ready. Does that work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context. I think we have enough time to fix any issues. Since this is only a bump, we should be ok
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti, sinnykumari, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This bump is instrumental to the development of OpenStack FailureDomains.