Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-5384: daemon: Explicitly pull image before running #3475

Merged
merged 1 commit into from Jan 6, 2023
Merged

[release-4.12] OCPBUGS-5384: daemon: Explicitly pull image before running #3475

merged 1 commit into from Jan 6, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3471

/assign cgwalters

@cgwalters
daemon: Explicitly pull image before running
0e1557e 
This is first just a generally good idea, because we often
want to apply different timeouts and runtime constraints to
the pull versus execution.

But second and more important, this should fix a bug we're seeing
where really old versions of podman that are in the 4.2 bootimages
don't honor `--authfile` when specified as part of `podman run`.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-4769 with correct target version. Retitling PR to link to clone:
/retitle [release-4.12] OCPBUGS-5384: daemon: Explicitly pull image before running

In response to this:

This is an automated cherry-pick of #3471

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-4769: daemon: Explicitly pull image before running [release-4.12] OCPBUGS-5384: daemon: Explicitly pull image before running Jan 6, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5384, which is invalid:

  • expected Jira Issue OCPBUGS-5384 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3471

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-5384: daemon: Explicitly pull image before running

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/jira refresh

@cgwalters
Copy link
Member

/payload 4.12 ci blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

@cgwalters: trigger 4 job(s) of type blocking for the ci release of OCP 4.12

  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6494ffe0-8def-11ed-9f09-7cbf17078b0a-0

@openshift-ci-robot
Copy link
Contributor

@cgwalters: This pull request references Jira Issue OCPBUGS-5384, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected Jira Issue OCPBUGS-5384 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@cgwalters: This pull request references Jira Issue OCPBUGS-5384, which is invalid:

  • expected Jira Issue OCPBUGS-5384 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jan 6, 2023

I set depends on links from OCPBUGS-5384 to OCPBUGS-4769:

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 6, 2023
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-5384, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4769 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-4769 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

I set depends on links from OCPBUGS-5384 to OCPBUGS-4769:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 6, 2023
@cheesesashimi
Copy link
Member

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 6, 2023
@cgwalters
Copy link
Member

/hold
until at least some key payload tests pass in https://pr-payload-tests.ci.openshift.org/runs/ci/6494ffe0-8def-11ed-9f09-7cbf17078b0a-0

I specifically want to verify at least one of the -upgrade tests works.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2023
@cgwalters
Copy link
Member

Hmm, coming up on 4 hours for the payload jobs. It's painful that we don't get any logs until the job is done...

@ashcrow
Copy link
Member

ashcrow commented Jan 6, 2023

cc'ing @vikaslaad for visibility

@cgwalters
Copy link
Member

Payload tests are green!
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2b3eba7 into openshift:release-4.12 Jan 6, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5384 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #3471

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@cgwalters cgwalters

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@sunilcio sunilcio

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rioliu-rh rioliu-rh

@mhanss mhanss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet