Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kubeletconfig to kubernetes@1.12.5 #350

Merged
merged 6 commits into from
Jan 28, 2019
Merged

Migrate kubeletconfig to kubernetes@1.12.5 #350

merged 6 commits into from
Jan 28, 2019

Conversation

abhinavdahiya
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 28, 2019
@rphillips
Copy link
Contributor

I'll take a look at the failure.

@rphillips
Copy link
Contributor

Looks like the CVO needs a bump, and the MCO code updated to use the newer CVO client:

        master: Could not introduce github.com/openshift/cluster-version-operator@master, as its subpackage github.com/openshift/cluster-version-operator/pkg/generated/clientset/versioned is missing. (Package is required by (root).)

@abhinavdahiya
Copy link
Contributor Author

Looks like the CVO needs a bump, and the MCO code updated to use the newer CVO client:

        master: Could not introduce github.com/openshift/cluster-version-operator@master, as its subpackage github.com/openshift/cluster-version-operator/pkg/generated/clientset/versioned is missing. (Package is required by (root).)

we should drop any code that imports CVO, we are not using anything from cluster version operator. The OperatorStatus moved to openshift/api/ config

@rphillips
Copy link
Contributor

/lgtm

nice job!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4ae668e into openshift:master Jan 28, 2019
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
@openshift-merge-robot
Merge pull request openshift#350 from multi-arch/master
aa144e2 
Bug 1766287: Improve usability of hello-openshift imagestream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips Awaiting requested review from rphillips

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@rphillips rphillips

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abhinavdahiya @rphillips @openshift-ci-robot @openshift-merge-robot