daemon: Handle osImageURL bootstrap #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
This is hoisted out of #324 |
ashcrow
reviewed
Feb 1, 2019
| if err != nil { | ||
| if os.IsNotExist(err) { |
There was a problem hiding this comment.
Why check if nothing different is done?
There was a problem hiding this comment.
Good catch, fixed thanks!
|
/retest |
We need special handling for the *initial* case where we boot into a target config, but we may be using an old OS image. Currently the MCD would treat this as "config drift" and go degraded. Today we write the node annotations to a file in `/etc` as part of the rendered Ignition. Use that as a "bootstrap may be required" flag, and handle it specially - if we need to pivot, do *just* that and reboot. We also clean things up by unlinking that node annotation file; after that, if the `osImageURL` drifts from the expected config, we'll go degraded, just like if someone modified a file.
cgwalters
force-pushed
the
cvo-integration-5-prep
branch
from
deb7201
to
8a7107e
Compare
jlebon
reviewed
Feb 1, 2019
| // currentConfig's osImageURL should now be *truth*. | ||
| // In other words if it drifts somehow, we go degraded. | ||
| if err := os.Remove(InitialNodeAnnotationsFilePath); err != nil { | ||
| return errors.Wrapf(err, "Removing initial node annotations file") |
|
Logs from PR: Though of course it's not doing anything yet. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
Remove hello-openshift imagestream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need special handling for the initial case where we boot
into a target config, but we may be using an old OS image. Currently
the MCD would treat this as "config drift" and go degraded.
Today we write the node annotations to a file in
/etcas part of therendered Ignition. Use that as a "bootstrap may be required" flag,
and handle it specially - if we need to pivot, do just that and
reboot.
We also clean things up by unlinking that node annotation file; after
that, if the
osImageURLdrifts from the expected config, we'll godegraded, just like if someone modified a file.