Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: Start sub-controllers in order of dependency #365

Merged
merged 1 commit into from
Feb 1, 2019
Merged

controller: Start sub-controllers in order of dependency #365

merged 1 commit into from
Feb 1, 2019

Conversation

cgwalters
Copy link
Member

The render controller needs kubelet data, so start it first.
And add a bit of docs.

@cgwalters
controller: Start sub-controllers in order of dependency
b5406ff 
The render controller needs kubelet data, so start it first.
And add a bit of docs.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 1, 2019
@cgwalters
Copy link
Member Author

This is not a fix for #338 - it will make it a bit less likely though and is prep for a real fix.

@ashcrow
Copy link
Member

ashcrow commented Feb 1, 2019

Agreed. I feel like having some more structure around ordering will help ... or at the very least make it easier to debug.

@jlebon
Copy link
Member

jlebon commented Feb 1, 2019

This looks sane to me, though I'd like @abhinavdahiya to take a look. I haven't really played much with this part of the code before.

@abhinavdahiya
Copy link
Contributor

No strong opinions on this, will defer to the team on this.

@ashcrow
Copy link
Member

ashcrow commented Feb 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5e872ab into openshift:master Feb 1, 2019
osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
@openshift-merge-robot
Merge pull request openshift#365 from gabemontero/bump-k8s-1.21-rc.0
ddbb0a3 
bump(k8s) 1.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@jlebon jlebon Awaiting requested review from jlebon

@wking wking Awaiting requested review from wking

Assignees

@ashcrow ashcrow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cgwalters @ashcrow @jlebon @abhinavdahiya @openshift-ci-robot @openshift-merge-robot