Commits on Apr 10, 2023

1. Accomodate ART limitation in parsing [[]] bash …

   The downstream build pipeline parses bash in Dockerfile `RUN` commands
   in order to smooth over yum/dnf invocations that break downstream builds.
   For example, upstream Dockerfiles may use `--disablerepo`  /
   `--enablerepo` / `microdnf` -- none of which will work as intended
   in brew/koji builds.
   
   The intent of this feature is to allow, to a reasonable extent, teams to
   use the same Dockerfile for upstream and downstream -- preventing the
   overhead of managing two nearly identical files.
   
   When processing changes introduced by
   openshift@c1f5e35 ,
   a limitation in the bashlex parser has been discovered where it cannot
   handle the (admittedly commonplace / proper) `[[ .. ]]` test syntax.
   
   Many OCP repos rely on this parsing feature, so the simplest course of
   action is to use the supported `[ .. ]` syntax in the MCO Dockerfile.

   

   jupierce committed Apr 10, 2023
   Copy the full SHA

   f56c1d3 View commit details

   Browse the repository at this point in the history