Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNET-303,OCPBUGS-25744: Remove weights from ingress check script #3698

Merged
merged 1 commit into from Mar 25, 2024

Commits on Jan 16, 2024

  1. OPNET-303: Remove weights from ingress check script

    Previously, because we had weights set for both check scripts for
    ingress, keepalived would always assign the ingress VIP somewhere,
    even if there were no ingress controllers available. While normally
    this is not a problem, this behavior is not ideal in circumstances
    such as remote workers where one worker per remote subnet will take
    the VIP because they can't coordinate with the other subnets.
    
    The advantage of removing the weight from the check script is that
    if there is no ingress controller running on the node it will never
    take the VIP, even if no other node in the cluster has taken it.
    This allows us to deploy remote workers without the extra step of
    disabling keepalived. As long as the ingress pods are deployed to
    the correct nodes keepalived will handle assigning the VIP on its
    own, even across subnets that can't communicate directly with each
    other.
    
    This also requires a modification to the keepalived liveness probe
    because previously we considered a FAULT state to be a failure. Now
    that we expect some nodes to be in a fault state we can't use that
    logic anymore. Since for our purposes we just need to verify that
    keepalived is functioning, just look for an expected line in the
    output instead of looking for a line that indicates an error.
    cybertron committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f0f13f5 View commit details
    Browse the repository at this point in the history