Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-1655: Apply node-cluster dashboard as a config map #3708

Merged
merged 1 commit into from Jul 25, 2023
Merged

OCPNODE-1655: Apply node-cluster dashboard as a config map #3708

merged 1 commit into from Jul 25, 2023

Conversation

sairameshv
Copy link
Member

@sairameshv sairameshv commented May 17, 2023 •
edited

- What I did
Added a configmap that creates a node related dashboard
- How to verify it
Install the cluster and observe a node-cluster configmap in the openshift-config-managed namespace.
Also find the node-cluster dashboard in the Observe/Dashboards section in the OCP UI
- Description for the changelog
Added a configmap that installs a node-cluster dashboard that contains some useful information about the node related components.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sairameshv sairameshv force-pushed the metrics branch 3 times, most recently from 2e4ea09 to c09c5a4 Compare June 6, 2023 11:35
@sairameshv sairameshv force-pushed the metrics branch 3 times, most recently from 8f1bad3 to cbdc07d Compare June 21, 2023 16:44
@sairameshv sairameshv marked this pull request as ready for review June 21, 2023 16:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@sairameshv sairameshv changed the title [DNM][Testing] Apply node-cluster dashboard as a config map Apply node-cluster dashboard as a config map Jun 21, 2023
@sairameshv
Copy link
Member Author

/cc @harche

@sairameshv
Copy link
Member Author

/retest

1 similar comment
@sairameshv
Copy link
Member Author

/retest

@harche
Copy link
Contributor

harche commented Jun 22, 2023

/hold till we finalize the node dashboard yaml

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@sairameshv
Add node related dashboard as a configmap
4249505 
Node dashboard contains useful information and metrics related to
the node components.
This Config map can be updated with the new metrics as and when required

Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
@sairameshv sairameshv changed the title Apply node-cluster dashboard as a config map OCPNODE-1655: Apply node-cluster dashboard as a config map Jul 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2023 •
edited by openshift-ci bot

@sairameshv: This pull request references OCPNODE-1655 which is a valid jira issue.

In response to this:

- What I did
Added a configmap that creates a node related dashboard
- How to verify it
Install the cluster and observe a node-cluster configmap in the openshift-config-managed namespace.
Also find the node-cluster dashboard in the Observe/Dashboards section in the OCP UI
- Description for the changelog
Added a configmap that installs a node-cluster dashboard that contains some useful information about the node related components.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

harche
harche approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@harche harche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@harche
Copy link
Contributor

harche commented Jul 25, 2023

/hold till we finalize the node dashboard yaml

/hold cancel

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@rphillips
Copy link
Contributor

lgtm

sinnykumari
sinnykumari reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: since this cm gets installed in openshift-config-managed namespace. Shouldn't this be part of that repo? Although I am not sure which repo this namespace belongs to.

@harche
Copy link
Contributor

harche commented Jul 25, 2023

One question: since this cm gets installed in openshift-config-managed namespace. Shouldn't this be part of that repo? Although I am not sure which repo this namespace belongs to.

@sinnykumari node monitoring dashboard (part of this PR) will be owned and maintained by the node team. Historically, we have used MCO to deliver node specific configurations, e.g. kubelet config. This is the reason we have decided to install this dashboard using MCO.

Etcd team uses their own operator to install their dashboard and that one gets installed in same openshift-config-managed namespace.

The monitoring dashboard has to be installed by applying a config map in openshift-config-managed namespace with payload containing the jsonnet for the dashboard. The operator that actually installs this config map could be any operator, in node team's case MCO would be the preferred choice.

@sinnykumari
Copy link
Contributor

makes sense, thanks for the explanation. Wanted to just make sure that we are consistent.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, sairameshv, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 312e16d into openshift:master Jul 25, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinnykumari sinnykumari sinnykumari left review comments

@harche harche harche approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sairameshv @harche @openshift-ci-robot @rphillips @sinnykumari @openshift-merge-robot