Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wasm extension #3776

Merged
merged 1 commit into from Jul 8, 2023
Merged

add wasm extension #3776

merged 1 commit into from Jul 8, 2023

Conversation

sohankunkerkar
Copy link
Member

xref: https://issues.redhat.com/browse/RFE-4177
related to openshift/os#1327

- What I did
This PR adds crun-wasm to the list of extensions.

- How to verify it

- Description for the changelog

@haircommander
Copy link
Member

/retest

haircommander
haircommander reviewed Jul 5, 2023
View reviewed changes
pkg/daemon/update.go Outdated Show resolved Hide resolved
@sohankunkerkar
add wasm extension
ffb664e 
xref: https://issues.redhat.com/browse/RFE-4177
related to openshift/os#1327
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar sohankunkerkar changed the title add crun-wasm extension add wasm extension Jul 5, 2023
@sohankunkerkar
Copy link
Member Author

/retest

@sohankunkerkar
Copy link
Member Author

/test okd-scos-e2e-aws-ovn

@sohankunkerkar
Copy link
Member Author

@haircommander could you take another look?

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@sohankunkerkar
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, sohankunkerkar, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ec8e0ab and 2 for PR HEAD ffb664e in total

@sohankunkerkar
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e852792 and 1 for PR HEAD ffb664e in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2023

@sohankunkerkar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn ffb664e link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2069e55 into openshift:master Jul 8, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sohankunkerkar @haircommander @openshift-ci-robot @yuqi-zhang @openshift-merge-robot