Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS: Rework to move everyone to toplevel, add runcom #378

Merged
merged 1 commit into from
Feb 5, 2019
Merged

OWNERS: Rework to move everyone to toplevel, add runcom #378

merged 1 commit into from
Feb 5, 2019

Conversation

cgwalters
Copy link
Member

We're reorganizing the teams to have part of the RHCOS team own
this operator too.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2019
@runcom
Copy link
Member

runcom commented Feb 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2019
@kikisdeliveryservice
Copy link
Contributor

/lgtm

@runcom
Copy link
Member

runcom commented Feb 4, 2019

is this file still needed though in pkg/daemon? https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/OWNERS

@cgwalters
OWNERS: Rework to move everyone to toplevel, add runcom
8bd3b25 
We're reorganizing the teams to have part of the RHCOS team own
this operator too.
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2019
@cgwalters
Copy link
Member Author

is this file still needed though in pkg/daemon? https://github.com/openshift/machine-config-operator/blob/master/pkg/daemon/OWNERS

Good call; thanks. I removed all of the "sub-OWNERS" ↑

@ashcrow
Copy link
Member

ashcrow commented Feb 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom
Copy link
Member

runcom commented Feb 4, 2019

/retest

@kikisdeliveryservice
Copy link
Contributor

/test e2e-aws-op

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 649451d into openshift:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcrow ashcrow ashcrow approved these changes

@jlebon jlebon Awaiting requested review from jlebon

@wking wking Awaiting requested review from wking

Assignees

@ashcrow ashcrow

@runcom runcom

@kikisdeliveryservice kikisdeliveryservice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cgwalters @runcom @kikisdeliveryservice @ashcrow @openshift-ci-robot @openshift-bot @openshift-merge-robot