Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16888: daemon: no need to reexec when target and source rhel version is same #3824

Merged
merged 1 commit into from Jul 27, 2023
Merged

OCPBUGS-16888: daemon: no need to reexec when target and source rhel version is same #3824

merged 1 commit into from Jul 27, 2023

Conversation

sinnykumari
Copy link
Contributor

- What I did

- How to verify it

- Description for the changelog

@sinnykumari sinnykumari changed the title daemon: no need to reexec when target and source rhel version is same OCPBUGS-16888: daemon: no need to reexec when target and source rhel version is same Jul 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 27, 2023
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Jira Issue OCPBUGS-16888, which is invalid:

  • expected the bug to target the "4.13.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-16888 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 27, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2023
@sergiordlr
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 27, 2023
@jupierce jupierce added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 27, 2023
@jupierce
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuqi-zhang
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 27, 2023
@sinnykumari
Copy link
Contributor Author

Created PR for 4.14 as well #3825

@jupierce jupierce removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 27, 2023
@sinnykumari
Copy link
Contributor Author

This is a low risk PR, in the essence of getting this PR tested in next nightly should be ok to get tests overridden. If we see later any regression, revert should be trivial

@jupierce jupierce merged commit 3e36a65 into openshift:release-4.13 Jul 27, 2023
6 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: Jira Issue OCPBUGS-16888: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16888 has been moved to the MODIFIED state.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari sinnykumari mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@jupierce jupierce

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet