install: Fix dash-to-hyhen for 04_kube_rbac_proxy_config.yaml prefix #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outgoing filename is from the manifest's creation in c02a9d2 (add support for operator metrics, 2023-01-25, openshift#3537), but it failed to match the 0000_<runlevel>_<dash-separated-component>_<manifest_filename> template [1]. This confused the cluster-version operator (CVO) about the intended runlevel, although with nothing else at level 80, that was not a problem. And it also resulted in it sorting before the other machine-config manifests, when the 04_... suggests it was intended to sort after 0000_80_machine-config-operator_03_rbac.yaml and such, although that also does not seem to have caused any problems. So no noticeable changes from this rename, but it will tidy things up a bit, and allow future CVOs to fail more aggressively on other filenames that diverge from the parseable template. Generated with: $ rename 's/0000_80-/0000_80_/' install/0000_80-machine-config-operator_04_kube_rbac_proxy_config.yaml $ git add -A install [1]: https://github.com/openshift/enhancements/blob/cafeb5c3cba7f8c9e261b2aabffa92e34dd76be6/dev-guide/cluster-version-operator/dev/operators.md#what-is-the-order-that-resources-get-createdupdated-in
Digging into gathered artifacts: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/3837/pull-ci-openshift-machine-config-operator-master-e2e-hypershift/1687187241517977600/artifacts/e2e-hypershift/dump-management-cluster/artifacts/hypershift-dump.tar | tar xOz hostedcluster-b1ef24f485273f324ff4-mgmt/cluster-scoped-resources/config.openshift.io/clusteroperators/console.yaml | yaml2json | jq -r '.status.conditions[] | .lastTransitionTime + " " + .type + "=" + .status + " " + .reason + ": " + .message'
2023-08-03T20:22:44Z Degraded=False AsExpected: RouteHealthDegraded: failed to GET route (https://console-openshift-console.apps.b1ef24f485273f324ff4-mgmt.ci.hypershift.devcluster.openshift.com): Get "https://console-openshift-console.apps.b1ef24f485273f324ff4-mgmt.ci.hypershift.devcluster.openshift.com": dial tcp: lookup console-openshift-console.apps.b1ef24f485273f324ff4-mgmt.ci.hypershift.devcluster.openshift.com on 172.29.0.10:53: no such host
2023-08-03T20:09:34Z Progressing=False AsExpected: All is well
2023-08-03T20:09:31Z Available=False RouteHealth_FailedGet: RouteHealthAvailable: failed to GET route (https://console-openshift-console.apps.b1ef24f485273f324ff4-mgmt.ci.hypershift.devcluster.openshift.com): Get "https://console-openshift-console.apps.b1ef24f485273f324ff4-mgmt.ci.hypershift.devcluster.openshift.com": dial tcp: lookup console-openshift-console.apps.b1ef24f485273f324ff4-mgmt.ci.hypershift.devcluster.openshift.com on 172.29.0.10:53: no such host
2023-08-03T20:22:39Z Upgradeable=True AsExpected: All is wellI'm having a hard time imagining a way that could be related to the change I'm making. /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outgoing filename is from the manifest's creation in c02a9d2 (#3537), but it failed to match the
0000_<runlevel>_<dash-separated-component>_<manifest_filename>template. This confused the cluster-version operator (CVO) about the intended runlevel, although with nothing else at level 80, that was not a problem. And it also resulted in it sorting before the other machine-config manifests, when the04_...suggests it was intended to sort after0000_80_machine-config-operator_03_rbac.yamland such, although that also does not seem to have caused any problems. So no noticeable changes from this rename, but it will tidy things up a bit, and allow future CVOs to fail more aggressively on other filenames that diverge from the parseable template.Generated with: