Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO-532: Finish lease type migration #3842

Merged
merged 1 commit into from Aug 8, 2023
Merged

MCO-532: Finish lease type migration #3842

merged 1 commit into from Aug 8, 2023

Conversation

djoshy
Copy link
Contributor

@djoshy djoshy commented Aug 7, 2023

- What I did
Changes the lease lock resource type from ConfigMapsLeases to LeasesResourceLock. We'll do a follow-up PR to clean up the old lease config maps in a later release.

- How to verify it
leader elections should work as before with no complaints, no timing weirdness etc

- Description for the changelog
migrate to LeasesResourceLock for leader elections

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2023 •
edited by openshift-ci bot

@djoshy: This pull request references MCO-532 which is a valid jira issue.

In response to this:

- What I did
Changes the lease lock resource type from ConfigMapsLeases to LeasesResourceLock. We'll do a follow-up PR to clean up the old lease config maps in a later release.

- How to verify it
leader elections should work as before with no complaints, no timing weirdness etc

- Description for the changelog
migrate to LeasesResourceLock for leader elections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@djoshy
Copy link
Contributor Author

djoshy commented Aug 7, 2023

/test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@jkyros
Copy link
Contributor

jkyros commented Aug 7, 2023

those were some weird (and completely unrelated) failures
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade

@djoshy djoshy marked this pull request as ready for review August 7, 2023 22:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@djoshy
Copy link
Contributor Author

djoshy commented Aug 8, 2023

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sergiordlr
Copy link

Verified using IPI on GCP

The controller pod can get the lease quickly even when we delete the pod several times

I0808 13:16:38.032156       1 leaderelection.go:245] attempting to acquire leader lease openshift-machine-config-operator/machine-config-controller...
I0808 13:16:38.047832       1 leaderelection.go:255] successfully acquired lease openshift-machine-config-operator/machine-config-controller

Same for the operator pod

I0808 13:15:29.439889       1 leaderelection.go:245] attempting to acquire leader lease openshift-machine-config-operator/machine-config...
I0808 13:15:29.451487       1 leaderelection.go:255] successfully acquired lease openshift-machine-config-operator/machine-config

When we enable the featuregate TechPreviewNoUpgrade, the time needed to acquire the lease is longer. This is a behavior that is not introduced by this PR and it is expected.

I0808 13:41:37.770545       1 leaderelection.go:245] attempting to acquire leader lease openshift-machine-config-operator/machine-config-controller...
I0808 13:44:12.105234       1 leaderelection.go:255] successfully acquired lease openshift-machine-config-operator/machine-config-controller

We can add the qe-approved label

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 8, 2023
@cdoern
Copy link
Contributor

cdoern commented Aug 8, 2023

/lgtm
/approve

looks simple enough :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 40571ad into openshift:master Aug 8, 2023
13 checks passed
@djoshy djoshy deleted the lease-migration branch September 12, 2023 17:28
praveenkumar added a commit to praveenkumar/crc that referenced this pull request Oct 20, 2023
@praveenkumar
cluster: Don't return error if there is no machine-config-controller …
4e1acda 
…configmap

OCP 4.14 moves to use LeasesResourceLock instead of ConfigMapsLeasesResourceLock and it
doesn't have this `machine-config-controller` configmap and `crc start`
failing on those bundle. This PR make sure if configmap doesn't present
then don't send the error.

- openshift/machine-config-operator#3842
anjannath pushed a commit to crc-org/crc that referenced this pull request Nov 7, 2023
@praveenkumar @anjannath
cluster: Don't return error if there is no machine-config-controller …
c501ebe 
…configmap

OCP 4.14 moves to use LeasesResourceLock instead of ConfigMapsLeasesResourceLock and it
doesn't have this `machine-config-controller` configmap and `crc start`
failing on those bundle. This PR make sure if configmap doesn't present
then don't send the error.

- openshift/machine-config-operator#3842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@cdoern cdoern

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@djoshy @openshift-ci-robot @jkyros @sergiordlr @cdoern @openshift-merge-robot