Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-17683: replace .. with : on registry CA file paths #3854

Merged
merged 1 commit into from Aug 15, 2023

Conversation

flavianmissi
Copy link
Member

Fixes: OCPBUGS-17683

- What I did
Replaced .. with a : in the registry related CA file paths.

- How to verify it

$ oc new-build -D $'FROM centos:7\nRUN yum install -y httpd'
# wait for build to finish
$ oc new-app centos:latest

- Description for the changelog
Fixes x509 error after node-ca removal (openshift/cluster-image-registry-operator#867)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
@flavianmissi flavianmissi force-pushed the OCPBUGS-17683 branch 5 times, most recently from 30e25a0 to 267b843 Compare August 14, 2023 12:54
@cdoern
Copy link
Contributor

cdoern commented Aug 14, 2023

/test unit

@flavianmissi flavianmissi changed the title wip: OCPBUGS-17683 replace .. with : on registry CA file paths OCPBUGS-17683 replace .. with : on registry CA file paths Aug 14, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
@cdoern
Copy link
Contributor

cdoern commented Aug 14, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2513389 and 2 for PR HEAD cafa7d7 in total

@xiuwang
Copy link

xiuwang commented Aug 15, 2023

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b46ed93 and 1 for PR HEAD cafa7d7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@flavianmissi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cf8e35e into openshift:master Aug 15, 2023
13 checks passed
@flavianmissi flavianmissi deleted the OCPBUGS-17683 branch August 15, 2023 09:19
@sinnykumari sinnykumari changed the title OCPBUGS-17683 replace .. with : on registry CA file paths OCPBUGS-17683: replace .. with : on registry CA file paths Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

@flavianmissi: Jira Issue OCPBUGS-17683: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17683 has been moved to the MODIFIED state.

In response to this:

Fixes: OCPBUGS-17683

- What I did
Replaced .. with a : in the registry related CA file paths.

- How to verify it

$ oc new-build -D $'FROM centos:7\nRUN yum install -y httpd'
# wait for build to finish
$ oc new-app centos:latest

- Description for the changelog
Fixes x509 error after node-ca removal (openshift/cluster-image-registry-operator#867)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@sinnykumari: Jira Issue OCPBUGS-17683 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants