Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNET-343: Restore node-ip for kubelet in dual-stack vSphere #3859

Merged

Conversation

mkowalski
Copy link
Contributor

@mkowalski mkowalski commented Aug 15, 2023

In #3518 we removed dual-stack --node-ip from vSphere setups due to the lack of support in Kubelet.

With K8s 1.27 and OCP 4.14 we get this functionality, so we can revert what we did in the mentioned above PR.

With this revert we are going to pass 2 IP addresses as --node-ip when running in dual-stack vSphere setup. This is now supported and needed to properly pass conformance tests.

Fixes: OPNET-343

In openshift#3518 we
removed dual-stack `--node-ip` from vSphere setups due to the lack of
support in Kubelet.

With K8s 1.27 and OCP 4.14 we get this functionality, so we can revert
what we did in the mentioned above PR.

With this revert we are going to pass 2 IP addresses as `--node-ip` when
running in dual-stack vSphere setup. This is now supported and needed to
properly pass conformance tests.

Fixes: OPNET-343
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2023

@mkowalski: This pull request references OPNET-343 which is a valid jira issue.

In response to this:

In #3518 we removed dual-stack --node-ip from vSphere setups due to the lack of support in Kubelet.

With K8s 1.27 and OCP 4.14 we get this functionality, so we can revert what we did in the mentioned above PR.

With this revert we are going to pass 2 IP addresses as --node-ip when running in dual-stack vSphere setup. This is now supported and needed to properly pass conformance tests.

Fixes: OPNET-343

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2023

@mkowalski: This pull request references OPNET-343 which is a valid jira issue.

In response to this:

In #3518 we removed dual-stack --node-ip from vSphere setups due to the lack of support in Kubelet.

With K8s 1.27 and OCP 4.14 we get this functionality, so we can revert what we did in the mentioned above PR.

With this revert we are going to pass 2 IP addresses as --node-ip when running in dual-stack vSphere setup. This is now supported and needed to properly pass conformance tests.

Fixes: OPNET-343

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor Author

/test e2e-vsphere

@mkowalski
Copy link
Contributor Author

/cc @cybertron
/cc @sinnykumari

@mkowalski
Copy link
Contributor Author

/cc @mrunalp

@openshift-ci openshift-ci bot requested a review from mrunalp August 15, 2023 11:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn ea77ba1 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the actual functionality is already in kube 1.27 and MCO has kube 1.27 deps in 4.14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 40dfd9b into openshift:master Aug 15, 2023
13 of 14 checks passed
@mkowalski mkowalski deleted the vsphere-dual-stack branch August 16, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants