Makefile: set GOCACHE=off in tests #391
Conversation
openshift-ci-robot
added
approved
|
Ah, I'd seen other projects doing this. /lgtm |
Follow in the footsteps of the MCO here: openshift/machine-config-operator#391 I definitely hit this in the past and couldn't understand why it wasn't rerunning the tests, but didn't bother to look deeper into it.
Follow in the footsteps of the MCO here: openshift/machine-config-operator#391 I definitely hit this in the past and couldn't understand why it wasn't rerunning the tests, but didn't bother to look deeper into it.
Since Go 1.10, test results get cached. This leads to the tests not being run sometimes because Go has cached the results and just assumes it will get the same results because the Go code hasn't changed. Set GOCACHE=off to get clean results everytime (this is especially good for us since we can poke at the cluster and rerun the test w/o having to change go code). Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
disable-go-cache
branch
from
0b284bc
to
cc16c57
Compare
|
removed GOCACHE=off from unit tests as we're not relying on external services there anyway so it's ok to cache ptal |
|
/retest |
1 similar comment
|
/retest |
|
good to go |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
flakes flakes flakes /retest |
|
/retest |
|
@runcom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Since Go 1.10, test results get cached. This leads to the tests not being run
sometimes because Go has cached the results and just assumes it will get the
same results because the Go code hasn't changed.
Set GOCACHE=off to get clean results everytime (this is especially good
for us since we can poke at the cluster and rerun the test w/o having to
change go code).
Signed-off-by: Antonio Murdaca runcom@linux.com