OCPBUGS-13044: daemon: always use podman cp to copy extensions container content

[sinnykumari]

In the past, we have been using oc image extract to get OS and extensions container content on node and only fallback to podman cp when oc fails. oc doesn't respect ICSP well and lead to bugs like https://issues.redhat.com/browse/OCPBUGS-13044. Since 4.12, we don't need to extract and copy os content on node. Now, using podman for extensions container will keep MCO completely honor ICSP.

- How to verify it
When we apply an extension, MCD pod log would show podman related log instead of oc image extract

[openshift-ci-robot]

@sinnykumari: This pull request references Jira Issue OCPBUGS-13044, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In the past, we have been using oc image extract to get OS and extensions container content on node and only fallback to podman cp when oc fails. oc doesn't respect ICSP well and lead to bugs like https://issues.redhat.com/browse/OCPBUGS-13044. Since 4.12, we don't need to extract and copy os content on node. Now, using podman for extensions container will keep MCO completely honor ICSP.

- How to verify it
When we apply an extension, MCD pod log would show podman related log instead of oc image extract

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sinnykumari]

/jira refresh

[openshift-ci-robot]

@sinnykumari: This pull request references Jira Issue OCPBUGS-13044, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgwalters]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6b6ca7d and 2 for PR HEAD 17bab99 in total

[openshift-ci]

@sinnykumari: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@sinnykumari: Jira Issue OCPBUGS-13044: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#3921

Jira Issue OCPBUGS-13044 has been moved to the MODIFIED state.

In response to this:

In the past, we have been using oc image extract to get OS and extensions container content on node and only fallback to podman cp when oc fails. oc doesn't respect ICSP well and lead to bugs like https://issues.redhat.com/browse/OCPBUGS-13044. Since 4.12, we don't need to extract and copy os content on node. Now, using podman for extensions container will keep MCO completely honor ICSP.

- How to verify it
When we apply an extension, MCD pod log would show podman related log instead of oc image extract

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sergiordlr]

This PR was pre-merge verified using IPI on GCP. It has been merged but we will paste the verification steps here anyway to track them.

When we install extensions we can see this messages in the MCD logs showing that we are using podman to extract the extensions image.

I0920 08:29:18.028306    1458 run.go:19] Running: nice -- ionice -c 3 podman pull -q --authfile /var/lib/kubelet/config.json registry.build03.ci.openshift.org/ci-ln-p8135pb/stable@sha256:24b9f0969be09c705cd1e4acf1169e660e572f271009fbe55b0bd35ba4fb9022
189fa0c3ab39a58096a4699e758445d3c1139345e25f9e4e34deef090f9f4171
I0920 08:29:18.918350    1458 rpm-ostree.go:307] Running captured: podman create --net=none --annotation=org.openshift.machineconfigoperator.pivot=true --name ostree-container-pivot-f055149b-3ebf-4bc7-81b7-4e4e565bd810 registry.build03.ci.openshift.org/ci-ln-p8135pb/stable@sha256:24b9f0969be09c705cd1e4acf1169e660e572f271009fbe55b0bd35ba4fb9022
I0920 08:29:18.985129    1458 run.go:19] Running: nice -- ionice -c 3 podman cp 7cd7d5a9ed1166a1e74f88d85e8da28e31cf6684fa9c496a5f8192c30bb4d690:/ /run/mco-extensions/os-extensions-content-56072104
I0920 08:29:25.416958    1458 update.go:1962] Running: chcon -R -t var_run_t /run/mco-extensions/os-extensions-content-56072104
I0920 08:29:25.575124    1458 update.go:1962] Running: rpm-ostree cleanup -p
Deployments unchanged.
I0920 08:29:25.723642    1458 update.go:1125] Applying extensions : ["update" "--install" "usbguard" "--install" "krb5-workstation" "--install" "libkadm5" "--install" "kernel-devel" "--install" "kernel-headers" "--install" "kata-containers"]

We have run all Critical and Layering test cases.

No problem was found, we can add the qe-approved label

/label qe-approved

[sinnykumari]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@sinnykumari: new pull request created: #3932

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.