[release-4.12] OCPBUGS-19659: After dual-stack conversion reconcile IPFamilies #3936
Conversation
This PR introduces a missing reconciliation of IPFamilies property in the ControllerConfig. A consequence of the reconciliation missing is that after conversion from single-stack to dual-stack the kubelet is still configured as single-stack because the underlying MCO's variable does not change its value. With this PR, when converting such a cluster, ControllerConfig will update the value and as a consequence reconfigure kubelet (specifically `--node-ip` param). Please note with this change we are introducing one reboot to the process of cluster conversion. Fixes: OCPBUGS-15910 Cherry-picks: openshift#3909
openshift-ci-robot
added
jira/valid-reference
|
@mkowalski: This pull request references Jira Issue OCPBUGS-19659, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@mkowalski: This pull request references Jira Issue OCPBUGS-19659, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@mkowalski: This pull request references Jira Issue OCPBUGS-19659, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cybertron can you LGTM ? I somehow missed it |
|
/retest-required |
|
/label backport-risk-assessed |
|
@mkowalski: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
jira/valid-bug
|
@cybertron: This pull request references Jira Issue OCPBUGS-19659, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, eurijon, mburman5, mhanss, rbbratta, reihl, rioliu-rh, rlobillo and sergiordlr
|
/label cherry-pick-approved |
|
@mkowalski: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zhaozhanqi Can you give this cherry-pick-approved? |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/assign @yuqi-zhang |
|
@cybertron: GitHub didn't allow me to assign the following users: yuqi-zhang. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, mkowalski, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 037db74
into
openshift:release-4.12
|
@mkowalski: Jira Issue OCPBUGS-19659: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19659 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.12.0-202403070139.p0.g037db74.assembly.stream.el8 for distgit ose-machine-config-operator. |
|
Fix included in accepted release 4.12.0-0.nightly-2024-03-07-031442 |
This PR introduces a missing reconciliation of IPFamilies property in the ControllerConfig. A consequence of the reconciliation missing is that after conversion from single-stack to dual-stack the kubelet is still configured as single-stack because the underlying MCO's variable does not change its value.
With this PR, when converting such a cluster, ControllerConfig will update the value and as a consequence reconfigure kubelet (specifically
--node-ipparam).Please note with this change we are introducing one reboot to the process of cluster conversion.
Fixes: OCPBUGS-15910
Cherry-picks: #3909