OCPBUGS-20338: dashboard should detect unknown and not ready for not ready dashboard

[kannon92]

Fixes: https://issues.redhat.com/browse/OCPBUGS-20338

- What I did
This dashboard is used to report the number of not ready nodes. If a node stops reporting its status, it is possible to have a condition status that says unknown rather than false. We should check for both unknown and false.

- How to verify it
I applied this yaml to an existing 4.14 cluster and verified that the query works.
- Description for the changelog

NodeNotReady should report both unknown and false for reporting unhealthy nodes.

[kannon92]

/cc @harche

[harche]

/lgtm

[rphillips]

/approve

[rphillips]

/relabel OCPBUGS-20338: dashboard should detect unknown and not ready for not ready dashboard

[rphillips]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/assign @yuqi-zhang

[rphillips]

/retitle OCPBUGS-20338: dashboard should detect unknown and not ready for not ready dashboard

[openshift-ci-robot]

@kannon92: This pull request references Jira Issue OCPBUGS-20338, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-20338

- What I did
This dashboard is used to report the number of not ready nodes. If a node stops reporting its status, it is possible to have a condition status that says unknown rather than false. We should check for both unknown and false.

- How to verify it
I applied this yaml to an existing 4.14 cluster and verified that the query works.
- Description for the changelog

NodeNotReady should report both unknown and false for reporting unhealthy nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/jira refresh

[openshift-ci-robot]

@rphillips: This pull request references Jira Issue OCPBUGS-20338, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rphillips]

/jira refresh

[openshift-ci-robot]

@rphillips: This pull request references Jira Issue OCPBUGS-20338, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yuqi-zhang]

logically lgtm. Please hold if we need pre-merge QE, but I think this is small enough that it should be fine to verify via bug

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, kannon92, mrunalp, rphillips, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kannon92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	1332c4e	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@kannon92: Jira Issue OCPBUGS-20338: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#3964

Jira Issue OCPBUGS-20338 has been moved to the MODIFIED state.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-20338

- What I did
This dashboard is used to report the number of not ready nodes. If a node stops reporting its status, it is possible to have a condition status that says unknown rather than false. We should check for both unknown and false.

- How to verify it
I applied this yaml to an existing 4.14 cluster and verified that the query works.
- Description for the changelog

NodeNotReady should report both unknown and false for reporting unhealthy nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@rphillips: new pull request created: #3966

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657