OCPBUGS-22200: Retry fetching OpenStack hostname if it fails

[mdbooth]

Common cause with #3979

- What I did

Firstly, a refactor to use an EnvironmentFile via a dropin on kubelet.service rather than systemd config in kubelet.service.d. This is a slightly nicer way of doing it and is consistent with the approach for AWS in #3979. It requires an upgrade to move any existing file to the new location and format, but this can be removed in a release after all legacy nodes have been upgraded.

Most significantly, updates the generator script to retry indefinitely until it gets a value returned.

- How to verify it

• Ensure a newly installed machine gets /etc/kubernetes/node.env correctly populated with instance name.
• Ensure an upgraded machine gets /etc/systemd/system/kubelet.service.d/20-openstack-node-name.conf upgraded to /etc/kubernetes/node.env. The upgrade will be logged in the openstack-kubelet-nodename system service on first boot after upgrade.
• Ensure nodename is set to instance name, not hostname, on clouds where these are different. I believe Vexxhost is a candidate.

- Description for the changelog

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-22200, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Common cause with #3979

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@mdbooth: This pull request references Jira Issue OCPBUGS-22200, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Common cause with #3979

- What I did

Firstly, a refactor to use an EnvironmentFile via a dropin on kubelet.service rather than systemd config in kubelet.service.d. This is a slightly nicer way of doing it and is consistent with the approach for AWS in #3979. It requires an upgrade to move any existing file to the new location and format, but this can be removed in a release after all legacy nodes have been upgraded.

Most significantly, updates the generator script to retry indefinitely until it gets a value returned.

- How to verify it

• Ensure a newly installed machine gets /etc/kubernetes/node.env correctly populated with instance name.
• Ensure an upgraded machine gets /etc/systemd/system/kubelet.service.d/20-openstack-node-name.conf upgraded to /etc/kubernetes/node.env. The upgrade will be logged in the openstack-kubelet-nodename system service on first boot after upgrade.
• Ensure nodename is set to instance name, not hostname, on clouds where these are different. I believe Vexxhost is a candidate.

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/test all

[openshift-ci]

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	c738160	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[EmilienM]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• templates/common/openstack/OWNERS [EmilienM,mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[EmilienM]

/retest-required

[openshift-ci-robot]

@mdbooth: Jira Issue OCPBUGS-22200: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#3990

Jira Issue OCPBUGS-22200 has been moved to the MODIFIED state.

In response to this:

Common cause with #3979

- What I did

Firstly, a refactor to use an EnvironmentFile via a dropin on kubelet.service rather than systemd config in kubelet.service.d. This is a slightly nicer way of doing it and is consistent with the approach for AWS in #3979. It requires an upgrade to move any existing file to the new location and format, but this can be removed in a release after all legacy nodes have been upgraded.

Most significantly, updates the generator script to retry indefinitely until it gets a value returned.

- How to verify it

• Ensure a newly installed machine gets /etc/kubernetes/node.env correctly populated with instance name.
• Ensure an upgraded machine gets /etc/systemd/system/kubelet.service.d/20-openstack-node-name.conf upgraded to /etc/kubernetes/node.env. The upgrade will be logged in the openstack-kubelet-nodename system service on first boot after upgrade.
• Ensure nodename is set to instance name, not hostname, on clouds where these are different. I believe Vexxhost is a candidate.

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2023-11-13-174800