OCPBUGS-7638: typo s/iface_default_hint_file/default_bridge_file/ #4004
Conversation
openshift-ci-robot
added
jira/severity-important
|
@rbbratta: This pull request references Jira Issue OCPBUGS-7638, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: rbbratta. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
``` configure-ovs.sh[8910]: ++ get_default_bridge_interface /var/lib/ovnk/iface_default_hint /etc/ovnk/extra_bridge /run/nodeip-configuration/primary-ip /etc/ovnk/default_bridge configure-ovs.sh[8910]: ++ local iface= configure-ovs.sh[8910]: ++ local counter=0 configure-ovs.sh[8910]: ++ local iface_default_hint_file=/var/lib/ovnk/iface_default_hint configure-ovs.sh[8910]: ++ local extra_bridge_file=/etc/ovnk/extra_bridge configure-ovs.sh[8910]: ++ local ip_hint_file=/run/nodeip-configuration/primary-ip configure-ovs.sh[8910]: ++ local default_bridge_file=/etc/ovnk/default_bridge configure-ovs.sh[8910]: ++ local extra_bridge= configure-ovs.sh[8910]: ++ '[' -f /etc/ovnk/extra_bridge ']' configure-ovs.sh[8910]: ++ '[' -f /etc/ovnk/default_bridge ']' configure-ovs.sh[8911]: +++ cat /var/lib/ovnk/iface_default_hint configure-ovs.sh[8911]: cat: /var/lib/ovnk/iface_default_hint: No such file or directory configure-ovs.sh[8910]: ++ iface= configure-ovs.sh[8910]: ++ '[' -z '' ']' configure-ovs.sh[8910]: ++ echo 'ERROR: User specified bridge file detected without any data' configure-ovs.sh[8910]: ++ exit 1 configure-ovs.sh[8883]: + iface='ERROR: User specified bridge file detected without any data' configure-ovs.sh[8883]: ++ handle_exit configure-ovs.sh[8883]: ++ e=1 ```
rbbratta
force-pushed
the
OCPBUGS-7638
branch
from
2bcd3d0
to
0c9872f
Compare
|
/cc @trozet |
|
@rbbratta: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cc @sinnykumari |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, rbbratta, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rbbratta: Jira Issue OCPBUGS-7638: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-7638 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-10-27-135451 |
typo s/iface_default_hint_file/default_bridge_file/
We are reading the wrong file.
This is why
[ -f ]checks are bad, they aren't atomic. Actually reading the file is the only true test.