Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCO-795: MCO-813: MCO-473: Implement Upgrade-Monitor, FeatureGate, and MachineConfigNode types #4012

Merged
merged 1 commit into from Nov 28, 2023
Merged

MCO-795: MCO-813: MCO-473: Implement Upgrade-Monitor, FeatureGate, and MachineConfigNode types #4012

merged 1 commit into from Nov 28, 2023

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Nov 1, 2023 •
edited

This introduces the management of the MachineConfigNode in techpreview.

MachineConfigNodes are per-node entities similar to the MachineConfigPool. Splitting state reporting into a per node basis allows users to see granular detail about what nodes are doing during an upgrade process.

The MCN data can be retrieved via oc get machineconfignodes and more information about conditions related to these nodes can be found in oc describe machineconfignodes. The state reporting here follows the metav1.Condition datatype where each "phase" of a node upgrade as it pertains to the MCO is tracked in a condition as well a printed as True/False/Unknown in oc get machineconfgnodes -o wide.

This datatype leaves the door open for more per node configuration as the only information in the spec is a node and pool reference currently.

A few things about MachineConfigNodes that a reviewer should know:

  1. the spec.configVersion.desiredConfig is always up to date with what the user wants. However, the status.configVersion.desiredConfig is only updated once the newly specified spec entity is validated in the MCO as a valid MCO and the MachineConfig-Diff is permitted.
  2. the general flow of an update is as follows:
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   True      False             False              False              False              False
ip-10-0-17-102.ec2.internal   True      False             False              False              False              False
ip-10-0-2-232.ec2.internal    True      False             False              False              False              False
ip-10-0-59-251.ec2.internal   True      False             False              False              False              False
ip-10-0-59-56.ec2.internal    True      False             False              False              False              False
ip-10-0-6-214.ec2.internal    True      False             False              False              False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     Unkown            False              False              False              False
ip-10-0-17-102.ec2.internal   True      False             False              False              False              False
ip-10-0-2-232.ec2.internal    True      False             False              False              False              False
ip-10-0-59-251.ec2.internal   True      False             False              False              False              False
ip-10-0-59-56.ec2.internal    True      False             False              False              False              False
ip-10-0-6-214.ec2.internal    True      False             False              False              False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              False              False                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                   False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              Unknown            False                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               False                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               Unknown                 False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                   False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                   False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                   False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                   False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                   False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                   False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                   False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                   False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                   False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                   False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                    Unknown           False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False             False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False             False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False             False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False             False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False             False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                     True               False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                     True              Unknown
ip-10-0-17-102.ec2.internal   True      False             False              False                    False             False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False             False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False             False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False             False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False             False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                     True              True
ip-10-0-17-102.ec2.internal   True      False             False              False                    False             False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False             False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False             False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False             False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False             False

where each parent phase goes through a false phase indicating nothing has happened yet, an unknown phase indicating the phase is in progress or has errored and a true phase indicating that this part of the update is complete.

Each parent phase is associated with 0+ children phases that can be shown via oc get machineconfignodes -o wide

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 1, 2023 •
edited by openshift-ci bot

@cdoern: This pull request references MCO-795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This introduces the management of the MachineConfigNode in techpreview.

MachineConfigNodes are per-node entities similar to the MachineConfigPool. Splitting state reporting into a per node basis allows users to see granular detail about what nodes are doing during an upgrade process.

The MCN data can be retrieved via oc get machineconfignodes and more information about conditions related to these nodes can be found in oc describe machineconfignodes. The state reporting here follows the metav1.Condition datatype where each "phase" of a node upgrade as it pertains to the MCO is tracked in a condition as well a printed as True/False/Unknown in oc get machineconfgnodes -o wide.

This datatype leaves the door open for more per node configuration as the only information in the spec is a node and pool reference currently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 1, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@cdoern
Copy link
Contributor Author

cdoern commented Nov 1, 2023

/test all

@cdoern cdoern force-pushed the upgrade-monitor branch 4 times, most recently from f3f0c93 to ca70e5b Compare November 8, 2023 14:52
@cdoern
Copy link
Contributor Author

cdoern commented Nov 8, 2023

/test all

@cdoern cdoern force-pushed the upgrade-monitor branch 3 times, most recently from 320d186 to 1847ca4 Compare November 10, 2023 16:27
@cdoern cdoern marked this pull request as ready for review November 10, 2023 16:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023
@cdoern cdoern force-pushed the upgrade-monitor branch 2 times, most recently from 81efddb to 709479c Compare November 10, 2023 19:33
@cdoern cdoern force-pushed the upgrade-monitor branch 9 times, most recently from a1c792f to c13931c Compare November 16, 2023 21:12
@yuqi-zhang
Copy link
Contributor

Just as an additional check

/payload 4.15 nightly blocking

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@yuqi-zhang: trigger 8 job(s) of type blocking for the nightly release of OCP 4.15

  • periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.15-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.15-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.15-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a4ed3ea0-8e0b-11ee-8a72-8acacfea252e-0

yuqi-zhang
yuqi-zhang reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments and cleanups

install/0000_80_machine-config-operator_01_machineconfigpool.crd.yaml Show resolved Hide resolved
pkg/controller/drain/drain_controller.go Outdated Show resolved Hide resolved
pkg/controller/drain/drain_controller.go Outdated Show resolved Hide resolved
pkg/controller/node/status.go Outdated Show resolved Hide resolved
pkg/upgrademonitor/upgrade_monitor.go Outdated Show resolved Hide resolved
pkg/operator/sync.go Outdated Show resolved Hide resolved
@rioliu-rh
Copy link

after review I tested following scenarios:

  1. RenderDegraded, e.g. MC contains empty ignition version, no rendered config is generated, MCN does not have any change: pass
  2. Add additional ssh key for user core, condition Cordoned is used to show Uncordon status, file bug OCPBUGS-24030 (not a blocker)
  3. Apply incompatible MC (karg is configured in ignition section), condition UpdateCompatible is Unknown: pass

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@cdoern: This pull request references MCO-795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This introduces the management of the MachineConfigNode in techpreview.

MachineConfigNodes are per-node entities similar to the MachineConfigPool. Splitting state reporting into a per node basis allows users to see granular detail about what nodes are doing during an upgrade process.

The MCN data can be retrieved via oc get machineconfignodes and more information about conditions related to these nodes can be found in oc describe machineconfignodes. The state reporting here follows the metav1.Condition datatype where each "phase" of a node upgrade as it pertains to the MCO is tracked in a condition as well a printed as True/False/Unknown in oc get machineconfgnodes -o wide.

This datatype leaves the door open for more per node configuration as the only information in the spec is a node and pool reference currently.

A few things about MachineConfigNodes that a reviewer should know:

  1. the spec.configVersion.desiredConfig is always up to date with what the user wants. However, the status.configVersion.desiredConfig is only updated once the newly specified spec entity is validated in the MCO as a valid MCO and the MachineConfig-Diff is permitted.
  2. the general flow of an update is as follows:
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   True      False             False              False              False              False
ip-10-0-17-102.ec2.internal   True      False             False              False              False              False
ip-10-0-2-232.ec2.internal    True      False             False              False              False              False
ip-10-0-59-251.ec2.internal   True      False             False              False              False              False
ip-10-0-59-56.ec2.internal    True      False             False              False              False              False
ip-10-0-6-214.ec2.internal    True      False             False              False              False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     Unkown            False              False              False              False
ip-10-0-17-102.ec2.internal   True      False             False              False              False              False
ip-10-0-2-232.ec2.internal    True      False             False              False              False              False
ip-10-0-59-251.ec2.internal   True      False             False              False              False              False
ip-10-0-59-56.ec2.internal    True      False             False              False              False              False
ip-10-0-6-214.ec2.internal    True      False             False              False              False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              False              False                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                   False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              Unknown            False                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               False                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               Unknown                 False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                   False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                   False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                   False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                   False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                   False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                    False              False
ip-10-0-17-102.ec2.internal   True      False             False              False                   False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                   False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                   False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                   False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                   False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                    Unknown           False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False             False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False             False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False             False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False             False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False             False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                     True               False
ip-10-0-17-102.ec2.internal   True      False             False              False                    False              False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False              False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False              False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False              False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False              False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                     True              Unknown
ip-10-0-17-102.ec2.internal   True      False             False              False                    False             False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False             False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False             False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False             False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False             False
$ oc get machineconfignodes
NAME                          UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETED   UPDATECOMPLETED   RESUMED
ip-10-0-12-194.ec2.internal   False     True              True               True                     True              True
ip-10-0-17-102.ec2.internal   True      False             False              False                    False             False
ip-10-0-2-232.ec2.internal    True      False             False              False                    False             False
ip-10-0-59-251.ec2.internal   True      False             False              False                    False             False
ip-10-0-59-56.ec2.internal    True      False             False              False                    False             False
ip-10-0-6-214.ec2.internal    True      False             False              False                    False             False

where each parent phase goes through a false phase indicating nothing has happened yet, an unknown phase indicating the phase is in progress or has errored and a true phase indicating that this part of the update is complete.

Each parent phase is associated with 0+ children phases that can be shown via oc get machineconfignodes -o wide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cheesesashimi
cheesesashimi reviewed Nov 28, 2023
View reviewed changes
pkg/daemon/daemon.go Outdated Show resolved Hide resolved
jkyros
jkyros reviewed Nov 28, 2023
View reviewed changes
hack/crds-sync.sh Outdated Show resolved Hide resolved
@jkyros jkyros mentioned this pull request Nov 28, 2023
Closed
@cdoern
Implement Upgrade-Monitor, FeatureGate, and MachineConfigNode types
956e787 
Signed-off-by: Charlie Doern <cdoern@redhat.com>
@cdoern
Copy link
Contributor Author

cdoern commented Nov 28, 2023

/test unit

1 similar comment
@cdoern
Copy link
Contributor Author

cdoern commented Nov 28, 2023

/test unit

@cdoern
Copy link
Contributor Author

cdoern commented Nov 28, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@yuqi-zhang
Copy link
Contributor

I believe the major concerns have been addressed. Given that:

  1. this is behind a featuregate
  2. QE pre-approval has been applied
  3. tests are passing, including payload jobs (the failed job was flaky and non of the failures appear related to the MCO)

I think we're ready to merge this and follow-up the remaining points. Thanks for the hard work everyone!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@cdoern: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 42ccb1a into openshift:master Nov 28, 2023
15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.15.0-202311290209.p0.g42ccb1a.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

@jkyros jkyros mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheesesashimi cheesesashimi cheesesashimi left review comments

@sinnykumari sinnykumari sinnykumari left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang left review comments

@jkyros jkyros jkyros left review comments

@cgwalters cgwalters Awaiting requested review from cgwalters

@djoshy djoshy Awaiting requested review from djoshy

@rioliu-rh rioliu-rh Awaiting requested review from rioliu-rh

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cdoern @openshift-ci-robot @sinnykumari @rioliu-rh @yuqi-zhang @openshift-bot @cheesesashimi @jkyros