bootstrap: Require images on command line #403
Conversation
openshift-ci-robot
added
approved
|
/test unit |
|
copy pasted /lgtm cancel |
|
And now if anyone wants to add a new MCO-managed image, they need to:
Or we change this bootstrap code to just parse the CVO payload directly which IMO would be saner, but this is the current status. |
There was a problem hiding this comment.
And now if anyone wants to add a new MCO-managed image, they need to:
- Add a CLI option here with a default
- Change the installer to pass that arg with the image from the CVO
- Make the option required here
Can we write this down somewhere? Either as a comment in the code, or somewhere in HACKING.md or something.
cgwalters
force-pushed
the
require-cvo-images
branch
from
016af4d
to
6448267
Compare
Since having a mismatch here will result in a broken cluster, change things so that the command line arguments are required and drop the `docker.io` image references. We never want to pull those into a real cluster. Ref: openshift#367
cgwalters
force-pushed
the
require-cvo-images
branch
from
6448267
to
648b910
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/flake /test e2e-aws |
|
these are really aws running out of resources, let's hold retesting for a while |
🤦♂️ |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Since having a mismatch here will result in a broken cluster,
change things so that the command line arguments are required
and drop the
docker.ioimage references. We never wantto pull those into a real cluster.
Ref: #367