New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: Require images on command line #403

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
7 participants
@cgwalters
Copy link
Contributor

cgwalters commented Feb 11, 2019

Since having a mismatch here will result in a broken cluster,
change things so that the command line arguments are required
and drop the docker.io image references. We never want
to pull those into a real cluster.

Ref: #367

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 11, 2019

/test unit

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 11, 2019

copy pasted /lgtm wrongly while reviewing other PRs lol but looks good

/lgtm cancel

@cgwalters

This comment has been minimized.

Copy link
Contributor Author

cgwalters commented Feb 11, 2019

And now if anyone wants to add a new MCO-managed image, they need to:

  • Add a CLI option here with a default
  • Change the installer to pass that arg with the image from the CVO
  • Make the option required here

Or we change this bootstrap code to just parse the CVO payload directly which IMO would be saner, but this is the current status.

@jlebon
Copy link
Member

jlebon left a comment

And now if anyone wants to add a new MCO-managed image, they need to:

  • Add a CLI option here with a default
  • Change the installer to pass that arg with the image from the CVO
  • Make the option required here

Can we write this down somewhere? Either as a comment in the code, or somewhere in HACKING.md or something.

Show resolved Hide resolved pkg/operator/images.go Outdated
Show resolved Hide resolved cmd/machine-config-operator/bootstrap.go Outdated
Show resolved Hide resolved pkg/operator/images.go Outdated

@cgwalters cgwalters force-pushed the cgwalters:require-cvo-images branch from 016af4d to 6448267 Feb 11, 2019

bootstrap: Require images on command line
Since having a mismatch here will result in a broken cluster,
change things so that the command line arguments are required
and drop the `docker.io` image references.  We never want
to pull those into a real cluster.

Ref: #367

@cgwalters cgwalters force-pushed the cgwalters:require-cvo-images branch from 6448267 to 648b910 Feb 11, 2019

@jlebon

This comment has been minimized.

Copy link
Member

jlebon commented Feb 11, 2019

/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 11, 2019

/flake

/test e2e-aws

@runcom

This comment has been minimized.

Copy link
Member

runcom commented Feb 11, 2019

these are really aws running out of resources, let's hold retesting for a while

@ashcrow

This comment has been minimized.

Copy link
Member

ashcrow commented Feb 12, 2019

these are really aws running out of resources, let's hold retesting for a while

🤦‍♂️

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 12, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3b4a34a into openshift:master Feb 12, 2019

6 checks passed

ci/prow/e2e-aws Job succeeded.
Details
ci/prow/e2e-aws-op Job succeeded.
Details
ci/prow/images Job succeeded.
Details
ci/prow/rhel-images Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment