OCPCLOUD-1609: Fix syntax in vsphere-hostname.yaml for CAPI machines #4037
Conversation
|
I have verified this on a vSphere CAPI cluster and finally got a machineset's machine up and running. The VM in the vCenter dashboard got up with correct ignition and DNS Name. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, odvarkadaniel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/label acknowledge-critical-fixes-only This is breaking some nodes booting because of the incorrect syntax, we need to fix this to restore the VM booting functionality |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
odvarkadaniel
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@odvarkadaniel: This pull request references OCPCLOUD-1609 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@odvarkadaniel: This pull request references OCPCLOUD-1609 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-hypershift |
|
@odvarkadaniel: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is a follow up to #3949 as I have introduced bash code that was not syntactically correct.