OCPBUGS-23085: MCO duplicates kernel arguments during firstboot

[ori-amizur]

During firstboot, if a kernel argument appears both in the boot command line and in the encapsulated machine config, this kernel argument is duplicated.
The reason for that is that current running configuration is not taken into account when updating the configuration before reboot. The solution is to use the current running configuration when updating during firstboot.
Fixes: OCPBUGS-23085

- What I did
Use the current running configuration when updating in firstboot.
- How to verify it
Add a kernel argument that appears also in the machine-config to firstboot, and see that it is not duplicated after reboot.
- Description for the changelog

Do not duplicate kernel arguments if they are present during firstboot

/cc @sinnykumari

[openshift-ci-robot]

@ori-amizur: This pull request references Jira Issue OCPBUGS-23085, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

During firstboot, if a kernel argument appears both in the boot command line and in the encapsulated machine config, this kernel argument is duplicated.
The reason for that is that current running configuration is not taken into account when updating the configuration before reboot. The solution is to use the current running configuration when updating during firstboot.
Fixes: OCPBUGS-23085

- What I did
Use the current running configuration when updating in firstboot.
- How to verify it
Add a kernel argument that appears also in the machine-config to firstboot, and see that it is not duplicated after reboot.
- Description for the changelog

Do not duplicate kernel arguments if they are present during firstboot

/cc @sinnykumari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ori-amizur]

/jira refresh

[openshift-ci-robot]

@ori-amizur: This pull request references Jira Issue OCPBUGS-23085, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ori-amizur]

/retest

[ori-amizur]

/test e2e-hypershift

[ori-amizur]

/retest

[ori-amizur]

/test e2e-hypershift

[rioliu-rh]

/hold for pre-merge testing if possible

[sergiordlr]

Pre-merge verified using SNO and the assisted installer.

Without the fix we were able to reproduce the problem configuring a "psi=1" kernel argument. We could see the duplicated kernel arg here:

$ cat /proc/cmdline 
BOOT_IMAGE=(hd0,gpt3)/ostree/rhcos-c5e81d34808e0eed7879f40b3d81087bbbfaa1425bad972fa159fdddec688c3c/vmlinuz-5.14.0-284.41.1.el9_2.x86_64 ignition.platform.id=metal ostree=/ostree/boot.0/rhcos/c5e81d34808e0eed7879f40b3d81087bbbfaa1425bad972fa159fdddec688c3c/0 psi=1 ip=ens3:dhcp root=UUID=d8e8a7d0-1273-4718-9078-9b75c6da7fc2 rw rootflags=prjquota boot=UUID=b7df50ac-05b0-4d4c-bd21-b0c577e1eb24 systemd.unified_cgroup_hierarchy=1 cgroup_no_v1=all psi=1

When we used the image with the fix we could see that the kernel argument was not duplicated anymore

$ cat /proc/cmdline 
BOOT_IMAGE=(hd0,gpt3)/ostree/rhcos-1cd772e18eae2dcd9c5b451650bd672deb228fcf104368fe0725bc5f77f313a5/vmlinuz-5.14.0-284.44.1.el9_2.x86_64 ignition.platform.id=metal ostree=/ostree/boot.0/rhcos/1cd772e18eae2dcd9c5b451650bd672deb228fcf104368fe0725bc5f77f313a5/0 ip=ens3:dhcp root=UUID=5701b4f3-92c7-4543-b1c6-e3265ae1328b rw rootflags=prjquota boot=UUID=6e1b8298-6035-4605-be58-f8c4a74c3d9a systemd.unified_cgroup_hierarchy=1 cgroup_no_v1=all psi=1

We can add the qe-approved label.
/label qe-approved

Thank you very much @ori-amizur for helping us and doing all the hard work in this verification process. I very much appreciate it. Thanks!!

[openshift-ci-robot]

@ori-amizur: This pull request references Jira Issue OCPBUGS-23085, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

During firstboot, if a kernel argument appears both in the boot command line and in the encapsulated machine config, this kernel argument is duplicated.
The reason for that is that current running configuration is not taken into account when updating the configuration before reboot. The solution is to use the current running configuration when updating during firstboot.
Fixes: OCPBUGS-23085

- What I did
Use the current running configuration when updating in firstboot.
- How to verify it
Add a kernel argument that appears also in the machine-config to firstboot, and see that it is not duplicated after reboot.
- Description for the changelog

Do not duplicate kernel arguments if they are present during firstboot

/cc @sinnykumari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sinnykumari]

/jira refresh
/approve
Will wait little bit to see if any other MCO team members have any concern.

[openshift-ci-robot]

@sinnykumari: This pull request references Jira Issue OCPBUGS-23085, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh
/approve
Will wait little bit to see if any other MCO team members have any concern.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sinnykumari]

Removing hold since qe testing has been done
/hold cancel

[cdoern]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, ori-amizur, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cdoern,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0229441 and 2 for PR HEAD dc8e0aa in total

[ori-amizur]

/retest

[ori-amizur]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5d8c005 and 1 for PR HEAD dc8e0aa in total

[ori-amizur]

/retest

[ori-amizur]

/test e2e-hypershift

[openshift-ci]

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ori-amizur: Jira Issue OCPBUGS-23085: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#4046

Jira Issue OCPBUGS-23085 has been moved to the MODIFIED state.

In response to this:

During firstboot, if a kernel argument appears both in the boot command line and in the encapsulated machine config, this kernel argument is duplicated.
The reason for that is that current running configuration is not taken into account when updating the configuration before reboot. The solution is to use the current running configuration when updating during firstboot.
Fixes: OCPBUGS-23085

- What I did
Use the current running configuration when updating in firstboot.
- How to verify it
Add a kernel argument that appears also in the machine-config to firstboot, and see that it is not duplicated after reboot.
- Description for the changelog

Do not duplicate kernel arguments if they are present during firstboot

/cc @sinnykumari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.16.0-202312131413.p0.g8477a99.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.