OCPBUGS-24030: add uncordon to mcn #4065

cdoern · 2023-12-07T21:10:11Z

we were using cordon to describe both cordon and uncordon in the MCN status

openshift-ci-robot · 2023-12-07T21:10:17Z

@cdoern: This pull request references Jira Issue OCPBUGS-24030, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

we were using cordon to describe both cordon and uncordon in the MCN status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rioliu-rh · 2023-12-08T00:28:02Z

/hold for verification

rioliu-rh · 2023-12-08T09:02:24Z

@cdoern when I try to list additional fields I cannot see Uncordoned, but I can find it in conditions

$ oc get machineconfignode ip-10-0-117-1.us-east-2.compute.internal -o yaml | yq '.status.conditions[].type'
"Resumed"
"UpdatePrepared"
"UpdateExecuted"
"UpdatePostActionComplete"
"UpdateComplete"
"UpdateCompatible"
"Drained"
"AppliedFilesAndOS"
"Cordoned"
"RebootedNode"
"ReloadedCRIO"
"Updated"
"Uncordoned"

$ oc get machineconfignode ip-10-0-117-1.us-east-2.compute.internal -o wide
NAME                                       UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATECOMPATIBLE   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   RELOADEDCRIO
ip-10-0-117-1.us-east-2.compute.internal   True      False            False            False                      False            False     False              False               False          False         False          False

I can find it in https://github.com/openshift/api/blob/master/machineconfiguration/v1alpha1/0000_80_machineconfignode-TechPreviewNoUpgrade.crd.yaml, is there anything I missed?

create a MC, monitor the condition, it can be updated.

{"lastTransitionTime":"2023-12-08T10:31:08Z","message":"UnCordoned node. The node is reporting Unschedulable = false","reason":"UpdateCompleteUncordoned","status":"True","type":"Uncordoned"}

cdoern · 2023-12-08T15:20:27Z

@rioliu-rh I think I forgot to update the CRD in the manifests Dir. I will push changes with that now.

we were using cordon to describe both cordon and uncordon in the MCN status Signed-off-by: Charlie Doern <cdoern@redhat.com>

rioliu-rh · 2023-12-11T05:41:25Z

verify with latest code
now I can see column UNCORDONEDNODE in output of oc get machineconfignode -o wide
the condition can be updated

$ mcn ip-10-0-15-42.us-east-2.compute.internal -o wide -w
NAME                                       UPDATED   UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATECOMPATIBLE   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   RELOADEDCRIO   UNCORDONEDNODE
ip-10-0-15-42.us-east-2.compute.internal   False     True             Unknown          False                      False            False     True               False               True           Unknown       False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             Unknown          False                      False            False     True               False               True           True          False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             Unknown          False                      False            False     True               False               True           True          False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             Unknown          False                      False            False     True               False               True           Unknown       False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             Unknown          False                      False            False     True               False               True           True          False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             Unknown          False                      False            False     True               Unknown             True           True          False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             True             False                      False            False     True               True                True           True          False          False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             True             Unknown                    False            False     True               True                True           True          Unknown        False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             True             True                       False            False     True               True                True           True          True           False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             True             True                       False            True      True               True                True           True          True           False          False
ip-10-0-15-42.us-east-2.compute.internal   False     True             True             True                       True             True      True               True                True           True          True           False          True
ip-10-0-15-42.us-east-2.compute.internal   False     True             True             True                       True             True      True               True                True           True          True           False          True
ip-10-0-15-42.us-east-2.compute.internal   True      False            False            False                      False            False     False              False               False          False         False          False          False

rioliu-rh · 2023-12-11T05:42:44Z

/label qe-approved
/unhold

openshift-ci-robot · 2023-12-11T05:42:53Z

@cdoern: This pull request references Jira Issue OCPBUGS-24030, which is invalid:

expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

we were using cordon to describe both cordon and uncordon in the MCN status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cdoern · 2023-12-11T20:24:35Z

/test all

cdoern · 2023-12-12T15:23:24Z

/jira refresh

openshift-ci-robot · 2023-12-12T15:23:30Z

@cdoern: This pull request references Jira Issue OCPBUGS-24030, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

djoshy · 2023-12-12T15:58:12Z

templates/master/01-master-kubelet/_base/files/kubelet.yaml

@@ -31,6 +31,7 @@ contents:
      AzureWorkloadIdentity: true
      BuildCSIVolumes: true
      CloudDualStackNodeIPs: true
+      DisableKubeletCloudCredentialProviders: false


overall lgtm from me! Just one minor thing: what does this template change do exactly?

this is to bring in some of the new featuregates that have been added to the default list

ack, sorry didn't catch that!

djoshy · 2023-12-13T16:25:21Z

/lgtm

openshift-ci · 2023-12-13T16:26:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cdoern,djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-12-13T18:06:02Z

/retest-required

Remaining retests: 0 against base HEAD 8477a99 and 2 for PR HEAD 4f000c9 in total

openshift-ci · 2023-12-13T20:00:18Z

@cdoern: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-12-13T20:01:41Z

@cdoern: Jira Issue OCPBUGS-24030: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24030 has been moved to the MODIFIED state.

In response to this:

we were using cordon to describe both cordon and uncordon in the MCN status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-14T01:01:42Z

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.16.0-202312140031.p0.gfe00a11.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2023

openshift-ci bot requested review from djoshy and yuqi-zhang December 7, 2023 21:10

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023

add uncordon to mcn

4f000c9

we were using cordon to describe both cordon and uncordon in the MCN status Signed-off-by: Charlie Doern <cdoern@redhat.com>

cdoern force-pushed the mcn-uncordoned branch from 948148b to 4f000c9 Compare December 8, 2023 15:25

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 11, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2023

openshift-ci bot requested a review from rioliu-rh December 12, 2023 15:23

djoshy reviewed Dec 12, 2023

View reviewed changes

openshift-ci bot assigned djoshy Dec 13, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023

openshift-merge-bot bot merged commit fe00a11 into openshift:master Dec 13, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-24030: add uncordon to mcn #4065

OCPBUGS-24030: add uncordon to mcn #4065

cdoern commented Dec 7, 2023

openshift-ci-robot commented Dec 7, 2023

rioliu-rh commented Dec 8, 2023

rioliu-rh commented Dec 8, 2023 •

edited

cdoern commented Dec 8, 2023

rioliu-rh commented Dec 11, 2023

rioliu-rh commented Dec 11, 2023

openshift-ci-robot commented Dec 11, 2023

cdoern commented Dec 11, 2023

cdoern commented Dec 12, 2023

openshift-ci-robot commented Dec 12, 2023

djoshy Dec 12, 2023

cdoern Dec 13, 2023

djoshy Dec 13, 2023

djoshy commented Dec 13, 2023

openshift-ci bot commented Dec 13, 2023

openshift-ci-robot commented Dec 13, 2023

openshift-ci bot commented Dec 13, 2023

openshift-ci-robot commented Dec 13, 2023

openshift-bot commented Dec 14, 2023

OCPBUGS-24030: add uncordon to mcn #4065

OCPBUGS-24030: add uncordon to mcn #4065

Conversation

cdoern commented Dec 7, 2023

openshift-ci-robot commented Dec 7, 2023

rioliu-rh commented Dec 8, 2023

rioliu-rh commented Dec 8, 2023 • edited

cdoern commented Dec 8, 2023

rioliu-rh commented Dec 11, 2023

rioliu-rh commented Dec 11, 2023

openshift-ci-robot commented Dec 11, 2023

cdoern commented Dec 11, 2023

cdoern commented Dec 12, 2023

openshift-ci-robot commented Dec 12, 2023

djoshy Dec 12, 2023

Choose a reason for hiding this comment

cdoern Dec 13, 2023

Choose a reason for hiding this comment

djoshy Dec 13, 2023

Choose a reason for hiding this comment

djoshy commented Dec 13, 2023

openshift-ci bot commented Dec 13, 2023

openshift-ci-robot commented Dec 13, 2023

openshift-ci bot commented Dec 13, 2023

openshift-ci-robot commented Dec 13, 2023

openshift-bot commented Dec 14, 2023

rioliu-rh commented Dec 8, 2023 •

edited