Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-1632: Bump k8s api to v0.29.0 #4119

Merged
merged 1 commit into from
Jan 22, 2024
Merged

OCPNODE-1632: Bump k8s api to v0.29.0 #4119

merged 1 commit into from
Jan 22, 2024

Conversation

QiWang19
Copy link
Member

- What I did
Update go.mod openshfit/api to get in API for sigstore CRDs, imagepolicy and clusterimagepolicy.
- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@QiWang19
Copy link
Member Author

/test all

@QiWang19 QiWang19 marked this pull request as ready for review January 14, 2024 19:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2024
cdoern
cdoern reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. However, I do want to be wary about k8s bumps and go version bumps. In testing, bumping k8s hasn't gone smoothly for me so we may want to run some extra tests

go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
@QiWang19
Copy link
Member Author

/retest-required

@QiWang19 QiWang19 changed the title Update go.mod Bump k8s api to v0.29.0 Jan 15, 2024
@cdoern
Copy link
Contributor

cdoern commented Jan 15, 2024

@QiWang19 please squash into one commit if this is ready to merge. The existing aws-ovn-upgrade failure seems like a flake. I am going to re-run

/test e2e-aws-ovn-upgrade

@QiWang19
Bump k8s api to v0.29.0
0f13b7a 
make go-deps
go mod vendor

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19
Copy link
Member Author

/retest-required

@mkowalski mkowalski mentioned this pull request Jan 16, 2024
Closed
@QiWang19
Copy link
Member Author

/retest

@QiWang19
Copy link
Member Author

@cdoern PTAL

@QiWang19
Copy link
Member Author

/retest

1 similar comment
@QiWang19
Copy link
Member Author

/retest

@QiWang19 QiWang19 changed the title Bump k8s api to v0.29.0 OCPNODE-1632: Bump k8s api to v0.29.0 Jan 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 18, 2024 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-1632 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

- What I did
Update go.mod openshfit/api to get in API for sigstore CRDs, imagepolicy and clusterimagepolicy.
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

/retest-required

@QiWang19
Copy link
Member Author

@cdoern @yuqi-zhang Can we get this in?

yuqi-zhang
yuqi-zhang approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/override ci/prow/e2e-gcp-op-single-node

Changes look safe, let's get the bump in early to facilitate later work

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op-single-node

In response to this:

/lgtm
/override ci/prow/e2e-gcp-op-single-node

Changes look safe, let's get the bump in early to facilitate later work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9fb0e62 and 2 for PR HEAD 0f13b7a in total

@hexfusion
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6745e60 and 1 for PR HEAD 0f13b7a in total

@hexfusion
Copy link
Contributor

/test e2e-gcp-op

1 similar comment
@QiWang19
Copy link
Member Author

/test e2e-gcp-op

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 139e1d0 and 0 for PR HEAD 0f13b7a in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0f13b7a was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2024
@mkowalski
Copy link
Contributor

/retest

Merging this will fix https://issues.redhat.com/browse/OCPBUGS-24573

@mkowalski
Copy link
Contributor

e2e-gcp-op-single-node job is permafailing since 20 December 2023, should be still marked as required in this repo?

@QiWang19
Copy link
Member Author

@yuqi-zhang PTAL

e2e-gcp-op-single-node job is permafailing since 20 December 2023, should be still marked as required in this repo?

@yuqi-zhang
Copy link
Contributor

I think so, https://issues.redhat.com/browse/OCPBUGS-26489 is the bug, and it's blocking any gcp-single-node deployments, so it's a good indicator. The fix has yet to be applied.

The MCO team will reconsider the value of this job on the MCO repo, though, maybe best as a release informing job instead

/hold cancel
/override ci/prow/e2e-gcp-op-single-node

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op-single-node

In response to this:

I think so, https://issues.redhat.com/browse/OCPBUGS-26489 is the bug, and it's blocking any gcp-single-node deployments, so it's a good indicator. The fix has yet to be applied.

The MCO team will reconsider the value of this job on the MCO repo, though, maybe best as a release informing job instead

/hold cancel
/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1cb3198 into openshift:master Jan 22, 2024
17 checks passed
@jkyros jkyros mentioned this pull request Jan 22, 2024
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.16.0-202401230706.p0.g1cb3198.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdoern cdoern cdoern left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@QiWang19 @cdoern @openshift-ci-robot @hexfusion @mkowalski @yuqi-zhang @openshift-bot