Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27162: Add dependency on crio-wipe to resolv-prepender #4146

Merged
merged 1 commit into from Feb 13, 2024

Conversation

cybertron
Copy link
Member

Because resolv-prepender can run very early in boot and it pulls an image, it can interfere with the functioning of the crio-wipe service after an unclean shutdown (such as a power outage). To avoid this, we can add a dependency to ensure crio-wipe will always complete before we start resolv-prepender.

- Description for the changelog
Added dependency on crio-wipe to resolv-prepender.

Because resolv-prepender can run very early in boot and it pulls an
image, it can interfere with the functioning of the crio-wipe service
after an unclean shutdown (such as a power outage). To avoid this,
we can add a dependency to ensure crio-wipe will always complete
before we start resolv-prepender.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@cybertron: This pull request references Jira Issue OCPBUGS-27162, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Because resolv-prepender can run very early in boot and it pulls an image, it can interfere with the functioning of the crio-wipe service after an unclean shutdown (such as a power outage). To avoid this, we can add a dependency to ensure crio-wipe will always complete before we start resolv-prepender.

- Description for the changelog
Added dependency on crio-wipe to resolv-prepender.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cybertron
Copy link
Member Author

/test e2e-metal-ipi
/test e2e-vsphere
/test e2e-metal-ipi-ovn-ipv6

@cybertron
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@cybertron: This pull request references Jira Issue OCPBUGS-27162, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cybertron
Copy link
Member Author

/retest-required

1 similar comment
@cybertron
Copy link
Member Author

/retest-required

@cybertron
Copy link
Member Author

/cc @mkowalski

@openshift-ci openshift-ci bot requested a review from mkowalski February 5, 2024 18:43
@mkowalski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024
@sinnykumari
Copy link
Contributor

LGTM
/approve

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 1b025b4 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 1b025b4 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bcb59f0 and 2 for PR HEAD 1b025b4 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 80d69d3 into openshift:master Feb 13, 2024
18 of 20 checks passed
@openshift-ci-robot
Copy link
Contributor

@cybertron: Jira Issue OCPBUGS-27162: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27162 has been moved to the MODIFIED state.

In response to this:

Because resolv-prepender can run very early in boot and it pulls an image, it can interfere with the functioning of the crio-wipe service after an unclean shutdown (such as a power outage). To avoid this, we can add a dependency to ensure crio-wipe will always complete before we start resolv-prepender.

- Description for the changelog
Added dependency on crio-wipe to resolv-prepender.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202402140210.p0.g80d69d3.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

stbenjam added a commit to stbenjam/machine-config-operator that referenced this pull request Feb 19, 2024
@cybertron
Copy link
Member Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@cybertron: new pull request created: #4293

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants