Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-28384: daemon: allow the user to override drains on IR changes #4150

Merged
merged 1 commit into from Feb 2, 2024
Merged

[release-4.14] OCPBUGS-28384: daemon: allow the user to override drains on IR changes #4150

merged 1 commit into from Feb 2, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4148

/assign yuqi-zhang

@yuqi-zhang
daemon: allow the user to override drains on IR changes
40b7165 
The MCO logic today allows users to not reboot when changing the
registries.conf file (through ICSP/IDMS/ITMS objects), but the MCO will
sometimes drain the node if the change is deemed "unsafe" (deleting a
mirror, for example).

This behaviour is very disruptive for some customers who with to make
all image registries changes non-disruptive. With this PR they can
create a ConfigMap and override the drain check.

Also add rbac for MCD to only read MCO-namespaced ConfigMaps.

To be used with support exception only.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28237 has been cloned as Jira Issue OCPBUGS-28384. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-28384: daemon: allow the user to override drains on IR changes

In response to this:

This is an automated cherry-pick of #4148

/assign yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-28237: daemon: allow the user to override drains on IR changes [release-4.14] OCPBUGS-28384: daemon: allow the user to override drains on IR changes Jan 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 26, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28384, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28237 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4148

/assign yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cdoern and djoshy January 26, 2024 22:16
@sinnykumari
Copy link
Contributor

/test unit

@sergiordlr
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 29, 2024
@sinnykumari
Copy link
Contributor

We need it until 4.14.
/lgtm
/label backport-risk-assessed

@sinnykumari
Copy link
Contributor

Retrying
/lgtm

@djoshy
Copy link
Contributor

djoshy commented Jan 29, 2024

My turn :P
/lgtm

/label backport-risk-assessed

@sinnykumari
Copy link
Contributor

Hopefully, bot is awake now :)
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 30, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@sinnykumari
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@sinnykumari: This pull request references Jira Issue OCPBUGS-28384, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28237 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28237 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b235299 and 2 for PR HEAD 40b7165 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024 •
edited

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-rt 40b7165 link false /test e2e-gcp-rt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuqi-zhang
Copy link
Contributor

/test e2e-aws-ovn-upgrade

@yuqi-zhang
Copy link
Contributor

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 88a0c2c into openshift:release-4.14 Feb 2, 2024
17 of 18 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28384: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28384 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #4148

/assign yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-proxy-pull-test-container-v4.14.0-202402022310.p0.g88a0c2c.assembly.stream for distgit openshift-proxy-pull-test.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2024-02-06-000359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdoern cdoern Awaiting requested review from cdoern

@djoshy djoshy Awaiting requested review from djoshy

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@yuqi-zhang yuqi-zhang

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet