Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-28926: [4.15] crio: update pids limit to be -1 #4163

Merged
merged 1 commit into from
Apr 25, 2024
Merged

OCPBUGS-28926: [4.15] crio: update pids limit to be -1 #4163

merged 1 commit into from
Apr 25, 2024

Conversation

haircommander
Copy link
Member

@haircommander haircommander commented Feb 2, 2024 •
edited

the default in cri-o 1.29 and below is 0, which is interpreted differently by runc and crun. The intended outcome of setting 0 was to set the cgroup limit to "max", so the pids limit is instead set by the kubelet's podPidsLimit.
After crun 1.13, both crun and runc correctly interpret a negative value as "max", so use this value instead to keep consistency.

@haircommander
crio: update pids limit to be -1
75a2948 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 2, 2024
@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander haircommander changed the base branch from master to release-4.15 February 2, 2024 19:09
@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is invalid:

  • expected Jira Issue OCPBUGS-28926 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

the default in cri-o 1.29 and below is 0, which is interpreted differently by runc and crun. The intended outcome of setting 0 was to set the cgroup limit to "max", so the pids limit is instead set by the kubelet's podPidsLimit.
After crun 1.13, both crun and runc correctly interpret a negative value as "max", so use this value instead to keep consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is invalid:

  • expected Jira Issue OCPBUGS-28926 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 2, 2024
@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-17635 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-17635 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @asahay19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member Author

/retest

3 similar comments
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

/retest

@lyman9966
Copy link

/label qe-approved

% oc rsh rhel-ubi
sh-4.2# cat /sys/fs/cgroup/pids.max
max

% oc debug node/ci-ln-0ilnv7t-72292-wd6pz-worker-a-kc4dk
sh-4.4# chroot /host
sh-5.1# cat /sys/fs/cgroup/kubepods.slice/pids.max
127194
sh-5.1# cat /sys/fs/cgroup/kubepods.slice/kubepods-besteffort.slice/pids.max
max
sh-5.1# cat /sys/fs/cgroup/kubepods.slice/kubepods-besteffort.slice/kubepods-besteffort-pod80eff7e2_a38d_4cf5_86d9_6c9ea0ff6c64.slice/pid.max
4096
sh-5.1# cat /sys/fs/cgroup/kubepods.slice/kubepods-burstable.slice/pids.max
max

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 12, 2024
@openshift-ci-robot
Copy link
Contributor

@haircommander: This pull request references Jira Issue OCPBUGS-28926, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-17635 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-17635 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @asahay19

In response to this:

the default in cri-o 1.29 and below is 0, which is interpreted differently by runc and crun. The intended outcome of setting 0 was to set the cgroup limit to "max", so the pids limit is instead set by the kubelet's podPidsLimit.
After crun 1.13, both crun and runc correctly interpret a negative value as "max", so use this value instead to keep consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member Author

/retest

@asahay19
Copy link

cc @lyman9966

@haircommander
Copy link
Member Author

/retest

1 similar comment
@haircommander
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024 •
edited

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 75a2948 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-vsphere-ovn 75a2948 link false /test okd-scos-e2e-vsphere-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 75a2948 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 75a2948 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-op 75a2948 link false /test okd-scos-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

/skip

@mrunalp mrunalp added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 4, 2024
@kolyshkin
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@mrunalp mrunalp added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: haircommander, kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6e28938 and 2 for PR HEAD 75a2948 in total

@openshift-merge-bot openshift-merge-bot bot merged commit b72184f into openshift:release-4.15 Apr 25, 2024
21 checks passed
@openshift-ci-robot
Copy link
Contributor

@haircommander: Jira Issue OCPBUGS-28926: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28926 has been moved to the MODIFIED state.

In response to this:

the default in cri-o 1.29 and below is 0, which is interpreted differently by runc and crun. The intended outcome of setting 0 was to set the cgroup limit to "max", so the pids limit is instead set by the kubelet's podPidsLimit.
After crun 1.13, both crun and runc correctly interpret a negative value as "max", so use this value instead to keep consistency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.15.0-202404251706.p0.gb72184f.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-04-26-110356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asahay19 asahay19 Awaiting requested review from asahay19

@mtrmac mtrmac Awaiting requested review from mtrmac

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rbbratta rbbratta

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet