[release-4.14] OPNET-355: Use NM's dns-change event for resolv.conf #4185
Conversation
NetworkManager starting from 1.42.2-12.el9_2 and 1.36.0-17.el8_6 adds a new event `dns-change` which is fired whenever a change to the DNS configuration happens. Thanks to this we no longer need to piggyback on other events (like `up` or `dhcp-change`) to detect when we need to potentially fix the content of `/etc/resolv.conf`. This change will reduce the overall number of calls to `resolv_prepender` as now it will be called only if DNS configuration could have been changed. We are still keeping the timeout for the `resolv_prepender` function because it is not expected that it would be running for longer than one minute. Closes: OPNET-355
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OPNET-355 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@mkowalski: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mkowalski: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkowalski, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mkowalski, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
|
@mkowalski: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close Need to be handled manually (there are 3 commits in a bundle to be backported) |
|
@mkowalski: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4133
/assign mkowalski