Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] TRT-1519: Revert #4129 "OCPBUGS-18940: Add keepalived healthcheck for machine-config-server" #4202

Closed

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Feb 19, 2024

Reverts #4129 ; tracked by TRT-1519

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Around 2/14, metal installs got worse, dropping by about 15%

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify metal payload jobs succeed

CC: @cybertron

PR created by Revertomatic™️

…eck"

This reverts commit 89e1675, reversing
changes made to bcb59f0.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2024

@stbenjam: This pull request references TRT-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4129 ; tracked by TRT-1519

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Around 2/14, metal installs got worse, dropping by about 15%

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify metal payload jobs succeed

CC: @cybertron

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

/hold

Just testing

@stbenjam stbenjam changed the title TRT-1519: Revert #4129 "OCPBUGS-18940: Add keepalived healthcheck for machine-config-server" [WIP] TRT-1519: Revert #4129 "OCPBUGS-18940: Add keepalived healthcheck for machine-config-server" Feb 19, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@stbenjam
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@stbenjam
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

1 similar comment
@stbenjam
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e27887e0-cf4f-11ee-89d4-7c64df0ef835-0

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e3b833d0-cf4f-11ee-8380-89bb5f45d4c9-0

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e6c46260-cf4f-11ee-9b73-00cf42414a0b-0

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

Not this one - install failures.

@stbenjam stbenjam closed this Feb 19, 2024
Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn c01ea3b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift c01ea3b link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants