OCPCLOUD-2462: Add Image Credential Provider flags for Kubelet on Azure

[theobarberbany]

- What I did

Adds configuration for the ACR credential provider to kubelet on Azure
Unit tests show new flags being set correctly.

Builds on #4103

Depends on the acr-credential-provider RPM shipping in RHCOS.

- How to verify it

Kubelet should be able to pull an image from a private ACR registry.

- Description for the changelog

Adds support for azure acr credential provider

[openshift-ci-robot]

@theobarberbany: This pull request references OCPCLOUD-2462 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

- What I did

Adds configuration for the ACR credential provider to kubelet on Azure
Unit tests show new flags being set correctly.

Builds on #4103

Depends on the acr-credential-provider RPM shipping in RHCOS.

- How to verify it

Kubelet should be able to pull an image from a private ACR registry.

- Description for the changelog

Adds support for azure acr credential provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[theobarberbany]

/jira refresh

[openshift-ci-robot]

@theobarberbany: This pull request references OCPCLOUD-2462 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/lgtm

[theobarberbany]

/retest-required

[JoelSpeed]

@theobarberbany Can you identify if there are any Azure E2Es that cover pulling from ACR and run those here using the /payload-job command if possible, else perhaps we can get some QE pre-merge sign off that this is in fact working

[theobarberbany]

I can't find any E2Es that are obviously pulling from ACR after a quick dig.

Let's ask QE, as discussed :)

[sunzhaohua2]

/label qe-approved
Tested before pr merge, pull image works well.

az acr login --name zhsunregistry
docker pull openshift/hello-openshift
docker tag openshift/hello-openshift:latest zhsunregistry.azurecr.io/hello-acr:latest
docker push zhsunregistry.azurecr.io/hello-acr:latest
oc new-project hello-acr
oc new-app --name hello-acr --allow-missing-images \
  --image zhsunregistry.azurecr.io/hello-acr:latest
$ oc get po                                                                                                                      
NAME                         READY   STATUS    RESTARTS   AGE
hello-acr-79d8cb6997-q85hv   1/1     Running   0          6s

[openshift-ci-robot]

@theobarberbany: This pull request references OCPCLOUD-2462 which is a valid jira issue.

In response to this:

- What I did

Adds configuration for the ACR credential provider to kubelet on Azure
Unit tests show new flags being set correctly.

Builds on #4103

Depends on the acr-credential-provider RPM shipping in RHCOS.

- How to verify it

Kubelet should be able to pull an image from a private ACR registry.

- Description for the changelog

Adds support for azure acr credential provider

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cheesesashimi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@theobarberbany: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	7701e25	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403070215.p0.g53bbe70.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.