New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30090: add node owner to MCN #4223
Conversation
@cdoern: This pull request references MCO-1051 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
for garbage collection, MCN object needs node as its owner. Signed-off-by: Charlie Doern <cdoern@redhat.com>
Now that you have owner references, the garbage collector will make sure old MCNs are reaped when the Node object is deleted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@cdoern: This pull request references Jira Issue OCPBUGS-30090, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@cdoern: This pull request references Jira Issue OCPBUGS-30090, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@cdoern: This pull request references Jira Issue OCPBUGS-30090, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@cdoern: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
1 similar comment
/retest-required |
922db99
into
openshift:master
@cdoern: Jira Issue OCPBUGS-30090: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30090 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403010908.p0.g922db99.assembly.stream.el8 for distgit ose-machine-config-operator. |
Fix included in accepted release 4.16.0-0.nightly-2024-03-05-105513 |
for garbage collection, MCN object needs node as its owner.