MCO-909: Openshift/Kubernetes 1.29 Rebase Updates

[dkhater-redhat]

- What I did
Update the go.mod, go.sum and vendor dependencies pointing to the kube1.29 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils.
- How to verify it

- Description for the changelog

[openshift-ci-robot]

@dkhater-redhat: This pull request references MCO-909 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

- What I did
Update the go.mod, go.sum and vendor dependencies pointing to the kube1.29 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils.
- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sinnykumari]

This looks great.
As part of story, we should also update openshift/library-go, openshift/api, openshift/runtime-utils and openshift/client-go so that we have openshift specific libs updated as well

[dkhater-redhat]

/retest

[openshift-ci]

@dkhater-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	68368e0	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sinnykumari]

Thanks for bumping OpenShift specific deps as well. This looks great. ci tests are passing, shouldn't need additional QE testing.
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dkhater-redhat,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

Just a heads-up that that the api has had few commits over the past night: https://github.com/openshift/api/commits/master/
The latest bump breaks a feature gate call within kubelet=config controller, I ran into this while testing some API changes.
So if we are holding off on merging this, it might be best to bump it again(and fix the calls) while we wait for the label reqt to get removed

[sinnykumari]

/hold
Thanks David for the bringing that up.
Is the breakage known and are getting fixed? Also, do you think this breakage will be caught-up by running any specific payload test on this PR?

[djoshy]

I couldn't built an MCO image with the api build - a function call arg/par list was changed, so we shouldn't need a payload test. Just trying to make the image locally(with bumping the api to github.com/openshift/api v0.0.0-20240314024039-4caef7fe3d0f should trigger the build failure

[sinnykumari]

Umm, image ci test and other tests are green on this PR. Am I missing something?

[djoshy]

This PR does not have the latest openshift api bump, the change I'm talking about happened somewhere in the last 3 commits(https://github.com/openshift/api/commits/master/)

[jkyros]

This PR does not have the latest openshift api bump, the change I'm talking about happened somewhere in the last 3 commits(https://github.com/openshift/api/commits/master/)

Yeah, Dalia and I were horsing with it last night trying to accommodate Eads' new ClusterProfile-centric feature gate stuff in openshift/api#1788, but I don't know that the MCO has the plumbing right now to figure out the cluster profile without doing something like Eads did here: https://github.com/openshift/cluster-config-operator/pull/411/files#r1520245798 ?

(Dalia is on it, and is following up, I'm just sharing it here to avoid duplicate investigations)

The tests are green here because I believe this moves the API version back to github.com/openshift/api v0.0.0-20240311132450-dcd6ab38a0f7 for now to avoid the feature gate commits from the last two days.

[djoshy]

Ah, thanks for the addn context John, I was trying to get some other API stuff working when I ran into it. I'm okay with merging as is if we want to override w the additional tag, but if we are waiting might as well try to patch it up, to help with other API efforts

[sinnykumari]

Ah, thanks John for the additional context. So, I think this should be good to go? We don't need latest changes for this bump. This is more of an exercise on what all changes we will need whenever a major version kube bump occurs in OCP.

[dkhater-redhat]

Yes exactly what John said 😄

The latest work for Openshift/api adds functionality that breaks our helper and bootstrap files by looking for a current 'ClusterProfile'. MCO doesn't have the functionality yet to capture this information, and I am going to follow up with Joel or David Eads on this matter today. However for this PR, I thought that the latest api changes over the past few days were not needed at this time.

if everything is good, does the PR look good for merge?

[sinnykumari]

Based on the conversation, this should be safe to get merged.
/hold cancel
This is not urgent, but don't see risk in getting it merged. @djoshy thoughts on adding acknowledge-critical-fixes-only ?

[djoshy]

I think it's safe to merge (:
/label acknowledge-critical-fixes-only