Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-30884: Prevent OVS-configuration to run before kdump #4259

Merged
merged 1 commit into from Mar 28, 2024
Merged

[release-4.15] OCPBUGS-30884: Prevent OVS-configuration to run before kdump #4259

merged 1 commit into from Mar 28, 2024
+10 −0

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4213

/assign sinnykumari

@jbtrystram
Prevent OVS-configuration to run before kdump
389e839 
Kdump will generate it's initramfs based on the running state when kdump.service run
If OVS has already run, the kdump fails to gather a working network config,
which prevent network log exports, sush as SSH.
See https://issues.redhat.com/browse/OCPBUGS-28239
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 13, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30239 has been cloned as Jira Issue OCPBUGS-30884. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-30884: Prevent OVS-configuration to run before kdump

In response to this:

This is an automated cherry-pick of #4213

/assign sinnykumari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-30239: Prevent OVS-configuration to run before kdump [release-4.15] OCPBUGS-30884: Prevent OVS-configuration to run before kdump Mar 13, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30884, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30239 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4213

/assign sinnykumari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jbtrystram
Copy link
Contributor

/retest

@jbtrystram
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2024
@openshift-ci-robot
Copy link
Contributor

@jbtrystram: This pull request references Jira Issue OCPBUGS-30884, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30239 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30239 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen March 25, 2024 08:33
@jbtrystram
Copy link
Contributor

/retest

@sinnykumari
Copy link
Contributor

/label backport-risk-assesed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@sinnykumari: The label(s) /label backport-risk-assesed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label backport-risk-assesed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 25, 2024
@sinnykumari
Copy link
Contributor

Clean backport
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@rioliu-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8437f35 and 2 for PR HEAD 389e839 in total

@jbtrystram
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dc0ffb0 and 1 for PR HEAD 389e839 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 389e839 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-op 389e839 link false /test okd-scos-e2e-gcp-op
ci/prow/okd-scos-e2e-vsphere-ovn 389e839 link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-vsphere-upi-zones 389e839 link false /test e2e-vsphere-upi-zones
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 389e839 link false /test okd-scos-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 36049f9 into openshift:release-4.15 Mar 28, 2024
14 of 19 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30884: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30884 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #4213

/assign sinnykumari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.15.0-202403280237.p0.g36049f9.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

@jbtrystram
Copy link
Contributor

/cherry-pick release-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2024
Merged
@openshift-cherrypick-robot
Copy link
Author

@jbtrystram: new pull request created: #4291

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-03-28-193516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@mike-nguyen mike-nguyen Awaiting requested review from mike-nguyen

Assignees

@rbbratta rbbratta

@sinnykumari sinnykumari

@eurijon eurijon

@mburman5 mburman5

@reihl reihl

@anuragthehatter anuragthehatter

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet