Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30852: add preferredduringscheduling annotation to kube-rbac-proxy-crio #4261

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Mar 14, 2024

Closes: #OCPBUGS-30852
- What I did
Added the annotation to the kube-rbac-proxy-crio pod.
- How to verify it
Check kube-rbac-proxy-crio pod in OCP and verify that these annotations exist on the pod.
- Description for the changelog

Add preferredDuringScheduling annotation to kube-rbac-proxy-crio

Signed-off-by: Kevin Hannon <kehannon@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 14, 2024
@openshift-ci-robot
Copy link
Contributor

@kannon92: This pull request references Jira Issue OCPBUGS-30852, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: #OCPBUGS-30852
- What I did
Added the annotation to the kube-rbac-proxy-crio pod.
- How to verify it
Check kube-rbac-proxy-crio pod in OCP and verify that these annotations exist on the pod.
- Description for the changelog

Add preferredDuringScheduling annotation to kube-rbac-proxy-crio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 14, 2024
@openshift-ci-robot
Copy link
Contributor

@kannon92: This pull request references Jira Issue OCPBUGS-30852, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92
Copy link
Contributor Author

/cc @rphillips

@openshift-ci openshift-ci bot requested a review from rphillips March 14, 2024 16:54
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@kannon92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn e058b98 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

@kannon92: This pull request references Jira Issue OCPBUGS-30852, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

Closes: #OCPBUGS-30852
- What I did
Added the annotation to the kube-rbac-proxy-crio pod.
- How to verify it
Check kube-rbac-proxy-crio pod in OCP and verify that these annotations exist on the pod.
- Description for the changelog

Add preferredDuringScheduling annotation to kube-rbac-proxy-crio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips
Copy link
Contributor

/lgtm
/approve

@rphillips
Copy link
Contributor

/cherrypick release-4.15

@openshift-cherrypick-robot

@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@rphillips
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f96548d into openshift:master Mar 15, 2024
16 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@kannon92: Jira Issue OCPBUGS-30852: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30852 has been moved to the MODIFIED state.

In response to this:

Closes: #OCPBUGS-30852
- What I did
Added the annotation to the kube-rbac-proxy-crio pod.
- How to verify it
Check kube-rbac-proxy-crio pod in OCP and verify that these annotations exist on the pod.
- Description for the changelog

Add preferredDuringScheduling annotation to kube-rbac-proxy-crio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@rphillips: new pull request created: #4264

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403180813.p0.gf96548d.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants