MCO-817: API Migration Cleanup: Populate kubelet.yaml template feature gates from featureGateAccessor #4270
Conversation
|
@dkhater-redhat: This pull request references MCO-817 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
need to fix the feature gate tests for this to pass |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkhater-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-op-single-node |
1 similar comment
|
/test e2e-gcp-op-single-node |
|
@dkhater-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
I opened this PR to test if i needed to fix the test to make it work without the default gates and ended up integrating this into another PR #4275, closing this one. |
|
@dkhater-redhat: This pull request references MCO-817 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/payload 4.16 ci blocking |
|
@dkhater-redhat: trigger 5 job(s) of type blocking for the ci release of OCP 4.16
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2b37cb70-f201-11ee-8d4a-00a98a9f2bfc-0 |
- What I did
removed the hardcoded values from the kubelet template. Cross verified by looking on the node to see if the featuregates matched.
- How to verify it
oc get featuregate cluster -o yaml
and
❯ oc debug node/ip-10-0-46-151.ec2.internal
sh-4.4# chroot /host
sh-5.1# cat etc/kubernetes/kubelet.conf
verify the feature gates are correctly enabled/disabled on the cluster
- Description for the changelog