TRT-1587: Revert #4275 "MCO-1092: Adapt the MCO's featuregate usage to new API"

[stbenjam]

Reverts #4275 ; tracked by TRT-1587

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This appears to be the cause of 8x increase in cluster-node-tuning-operator watches on some resources.

Now:

$ kubectl dev-tool audit -f ~/Downloads/ci-op-izsh1s5q-f9945-5vc6b-master-1-audit.log --verb=watch --user=system:serviceaccount:openshift-cluster-node-tuning-operator:cluster-node-tuning-operator -o top --by resource
count: 149, first: 2024-03-29T02:02:53-04:00, last: 2024-03-29T02:33:02-04:00, duration: 30m8.853076s
64x                  machineconfiguration.openshift.io/v1/machineconfigpools
32x                  machineconfiguration.openshift.io/v1/kubeletconfigs
7x                   v1/nodes
7x                   machineconfiguration.openshift.io/v1/machineconfigs
6x                   tuned.openshift.io/profiles
6x                   tuned.openshift.io/tuneds
3x                   config.openshift.io/v1/featuregates
3x                   config.openshift.io/v1/clusteroperators
3x                   performance.openshift.io/v2/performanceprofiles
3x                   node.k8s.io/v1/runtimeclasses

Previously:

$ kubectl dev-tool audit -f ~/Downloads/ci-op-rfi6ctq1-f9945-4vk5d-master-1-audit.log --verb=watch --user=system:serviceaccount:openshift-cluster-node-tuning-operator:cluster-node-tuning-operator -o top --by resource
count: 74, first: 2024-02-01T18:36:39-05:00, last: 2024-02-01T19:05:26-05:00, duration: 28m46.585866s
8x                   v1/nodes
8x                   tuned.openshift.io/profiles
7x                   machineconfiguration.openshift.io/v1/machineconfigpools
7x                   machineconfiguration.openshift.io/v1/machineconfigs
6x                   tuned.openshift.io/tuneds
4x                   machineconfiguration.openshift.io/v1/containerruntimeconfigs
4x                   node.k8s.io/v1/runtimeclasses
4x                   performance.openshift.io/v2/performanceprofiles
4x                   machineconfiguration.openshift.io/v1/kubeletconfigs
4x                   config.openshift.io/v1/featuregates

Now:

Before this PR:

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of [sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel] on these jobs to confirm the fix has corrected the problem:

/payload 4.16 ci blocking

CC: @dkhater-redhat

PR created by Revertomatic^™️

[openshift-ci-robot]

@stbenjam: This pull request references TRT-1587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4275 ; tracked by TRT-1587

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Floating a revert to see if this is the cause of cluster-node-tuning-operator watches doubling

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @dkhater-redhat

PR created by Revertomatic^™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stbenjam: This pull request references TRT-1587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4275 ; tracked by TRT-1587

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Floating a revert to see if this is the cause of cluster-node-tuning-operator watches doubling

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @dkhater-redhat

PR created by Revertomatic^™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stbenjam]

/hold
/payload 4.16 ci blocking

[openshift-ci]

@stbenjam: trigger 5 job(s) of type blocking for the ci release of OCP 4.16

• periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
• periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-azure-sdn-upgrade
• periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-upgrade
• periodic-ci-openshift-release-master-ci-4.16-e2e-aws-sdn-serial
• periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d8401bb0-edce-11ee-9ce6-6e4383f23f64-0

[neisw]

/lgtm
tagging now but holding for verification.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neisw, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign jkyros for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@stbenjam: This pull request references TRT-1587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4275 ; tracked by TRT-1587

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Floating a revert to see if this is the cause of 8x increase in some cluster-node-tuning-operator watches

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @dkhater-redhat

PR created by Revertomatic^™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stbenjam: This pull request references TRT-1587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4275 ; tracked by TRT-1587

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This appears to be the cause of 8x increase in cluster-node-tuning-operator watches.

Now:

Before this PR:

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload 4.16 ci blocking

CC: @dkhater-redhat

PR created by Revertomatic^™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stbenjam: This pull request references TRT-1587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #4275 ; tracked by TRT-1587

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This appears to be the cause of 8x increase in cluster-node-tuning-operator watches.

Now:

Before this PR:

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of [sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel] on these jobs to confirm the fix has corrected the problem:

/payload 4.16 ci blocking

CC: @dkhater-redhat

PR created by Revertomatic^™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stbenjam]

/hold cancel
/label approved
/skip
/override ci/prow/e2e-hypershift
/override ci/prow/security
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-openstack
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-gcp-op-techpreview
/override ci/prow/e2e-azure-ovn-upgrade-out-of-change
/override ci/prow/e2e-gcp-op

[openshift-ci]

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-aws-ovn-upgrade-out-of-change, ci/prow/e2e-azure-ovn-upgrade-out-of-change, ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-gcp-op-techpreview, ci/prow/e2e-hypershift, ci/prow/e2e-openstack, ci/prow/okd-scos-e2e-aws-ovn, ci/prow/security

In response to this:

/hold cancel
/label approved
/skip
/override ci/prow/e2e-hypershift
/override ci/prow/security
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-openstack
/override ci/prow/okd-scos-e2e-aws-ovn
/override ci/prow/e2e-gcp-op-techpreview
/override ci/prow/e2e-azure-ovn-upgrade-out-of-change
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403291345.p0.g1d5df20.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.