Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds ocb api e2e tests #4328

Closed
wants to merge 4 commits into from
Closed

adds ocb api e2e tests #4328

wants to merge 4 commits into from

Conversation

cheesesashimi
Copy link
Member

- What I did

Updated e2e tests for OCB API.

- How to verify it

Run the e2e test suite.

- Description for the changelog
Updates e2e tests to use OCB API

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@cheesesashimi cheesesashimi changed the title adds ocb api tests adds ocb api e2e tests Apr 17, 2024
@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op-techpreview

umohnani8
umohnani8 reviewed Apr 18, 2024
View reviewed changes
test/e2e-techpreview/onclusterbuild_test.go Outdated

t.Logf("Wait for build to start")
waitForPoolToReachState(t, cs, testOpts.poolName, func(mcp *mcfgv1.MachineConfigPool) bool {
return ctrlcommon.NewMachineOSBuildState(mcp).IsBuilding()
waitForMachineOSBuildToReachState(t, cs, testOpts.poolName, func(mosb *mcfgv1alpha1.MachineOSBuild) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I think I am missing this but where is mosb being generated or created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding, the MachineOSBuild object is created in response to the MachineOSConfig object.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
cdoern and others added 2 commits April 19, 2024 07:06
@cdoern @inesqyx
ocb-api
a1818d5 
Signed-off-by: Charlie Doern <cdoern@redhat.com>
@inesqyx
further cleanup
fbbb0ab
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op-techpreview

@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op-techpreview

I think the reason this failed is because it leaves a MachineOSBuild object around even when all of the configs and pools related to it are deleted. I've added a post-test cleanup function to ensure that everything is removed between each test.

@cheesesashimi cheesesashimi mentioned this pull request Apr 23, 2024
Closed
@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op-techpreview

The test cluster failed to come up for reasons that appear unrelated to this PR. Retrying.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview eb57b05 link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op-techpreview

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheesesashimi
Copy link
Member Author

These changes were incorporated into #4327, so this PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umohnani8 umohnani8 umohnani8 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cheesesashimi @openshift-merge-robot @umohnani8 @cdoern @inesqyx