Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-32472: Delete state files on reboot only #4331

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

[release-4.14] OCPBUGS-32472: Delete state files on reboot only #4331

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4311

/assign MarSik

@MarSik
OCPBUGS-24366: Delete state files on reboot only
5b8763a 
The original kubelet.service definition deletes the cpu and memory
manager state files on every kubelet restart. That causes a loss
of cpu manager information and new cpu allocations the pods are
not expecting.

Splitting the kubelet.service into two parts should fix this.

- kubelet.service no longer deletes the state files on restart
- kubelet-cleanup.service is an oneshot before=kubelet service
  that only executes once at boot and performs the cleanup
  after reboot.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 19, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28545 has been cloned as Jira Issue OCPBUGS-32472. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-32472: Delete state files on reboot only

In response to this:

This is an automated cherry-pick of #4311

/assign MarSik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-28545: Delete state files on reboot only [release-4.14] OCPBUGS-32472: Delete state files on reboot only Apr 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 19, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-32472, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-28545 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4311

/assign MarSik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MarSik
Copy link
Contributor

MarSik commented Apr 19, 2024

/hold

This depends on: openshift/origin#28620 and openshift/kubernetes#1951

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-zones 5b8763a link false /test e2e-vsphere-zones
ci/prow/e2e-vsphere-upi-zones 5b8763a link false /test e2e-vsphere-upi-zones
ci/prow/e2e-hypershift 5b8763a link true /test e2e-hypershift
ci/prow/okd-images 5b8763a link false /test okd-images
ci/prow/e2e-aws-ovn-fips 5b8763a link false /test e2e-aws-ovn-fips
ci/prow/okd-scos-e2e-aws-ovn 5b8763a link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn 5b8763a link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdoern cdoern Awaiting requested review from cdoern

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@MarSik MarSik

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @MarSik