OCPBUGS-32922: [release-4.15] add cluster fleet evaluation support to mco

[rphillips]

Backports #4316 to 4.15.

[openshift-ci-robot]

@rphillips: This pull request references Jira Issue OCPBUGS-32922, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-32138 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backports #4316 to 4.15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rphillips]

/label backport-risk-assessed

[openshift-ci]

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	8fe1f69	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-vsphere-ovn	8fe1f69	link	false	/test okd-scos-e2e-vsphere-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	8fe1f69	link	false	/test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-op-layering	8fe1f69	link	false	/test e2e-gcp-op-layering
ci/prow/okd-scos-e2e-gcp-op	8fe1f69	link	false	/test okd-scos-e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rphillips]

/jira refresh

[openshift-ci-robot]

@rphillips: This pull request references Jira Issue OCPBUGS-32922, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-32138 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-32138 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[QiWang19]

/lgtm

[rphillips]

/unassign @ptalgulk01 @mhanss
/assign @sinnykumari @yuqi-zhang for approvals

[yuqi-zhang]

Sane backport

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, rphillips, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lyman9966]

/label qe-approved
1)oc get clusteroperators.config.openshift.io machine-config -o yaml | grep EvaluationConditionsDetected -B 3

• lastTransitionTime: "2024-04-12T13:03:04Z"
  reason: AsExpected
  status: "False"
  type: EvaluationConditionsDetected
  2)Applying:
  apiVersion: machineconfiguration.openshift.io/v1
  kind: KubeletConfig
  metadata:
  name: set-worker-kube-config
  spec:
  machineConfigPoolSelector:
  matchLabels:
  pools.operator.machineconfiguration.openshift.io/worker: ""
  kubeletConfig:
  failSwapOn: false
  3)oc get clusteroperators.config.openshift.io machine-config -o yaml | grep EvaluationConditionsDetected -B 3
• lastTransitionTime: "2024-04-30T05:01:00Z"
  reason: 'failswapon: KubeletConfig setting is currently unsupported by OpenShift'
  status: "True"
  type: EvaluationConditionsDetected
  4)Applying:
  apiVersion: machineconfiguration.openshift.io/v1
  kind: ContainerRuntimeConfig
  metadata:
  name: set-runtime
  spec:
  machineConfigPoolSelector:
  matchLabels:
  pools.operator.machineconfiguration.openshift.io/worker: ""
  containerRuntimeConfig:
  defaultRuntime: "runc"
  5)oc get clusteroperators.config.openshift.io machine-config -o yaml | grep EvaluationConditionsDetected -B 3
  reason: 'failswapon: KubeletConfig setting is currently unsupported by OpenShift::runc:
  transition to default crun'
  status: "True"
  type: EvaluationConditionsDetected
  6)Applying:
  apiVersion: config.openshift.io/v1
  kind: Node
  metadata:
  name: cluster
  spec:
  cgroupMode: v1
  7)oc get clusteroperators.config.openshift.io machine-config -o yaml | grep EvaluationConditionsDetected -B 5
• lastTransitionTime: "2024-04-30T05:01:00Z"
  reason: 'cgroupsv1: support has been deprecated in favor of cgroupsv2::failswapon:
  KubeletConfig setting is currently unsupported by OpenShift::runc: transition
  to default crun'
  status: "True"
  type: EvaluationConditionsDetected

[sunilcio]

/label cherry-pick-approved

[openshift-ci-robot]

@rphillips: Jira Issue OCPBUGS-32922: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#4334

Jira Issue OCPBUGS-32922 has been moved to the MODIFIED state.

In response to this:

Backports #4316 to 4.15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.15.0-202404301242.p0.g1b35c4e.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-04-30-234425

[rphillips]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@rphillips: #4334 failed to apply on top of branch "release-4.14":

Applying: add cluster fleet evaluation support to mco
Using index info to reconstruct a base tree...
M	cmd/machine-config-operator/start.go
M	pkg/controller/kubelet-config/helpers.go
M	pkg/controller/kubelet-config/kubelet_config_controller.go
M	pkg/controller/kubelet-config/kubelet_config_controller_test.go
M	pkg/controller/kubelet-config/kubelet_config_features_test.go
M	pkg/controller/kubelet-config/kubelet_config_nodes_test.go
M	pkg/operator/operator.go
M	pkg/operator/status.go
M	pkg/operator/sync.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/sync.go
Auto-merging pkg/operator/status.go
CONFLICT (content): Merge conflict in pkg/operator/status.go
Auto-merging pkg/operator/operator.go
CONFLICT (content): Merge conflict in pkg/operator/operator.go
Auto-merging pkg/controller/kubelet-config/kubelet_config_nodes_test.go
Auto-merging pkg/controller/kubelet-config/kubelet_config_features_test.go
CONFLICT (content): Merge conflict in pkg/controller/kubelet-config/kubelet_config_features_test.go
Auto-merging pkg/controller/kubelet-config/kubelet_config_controller_test.go
Auto-merging pkg/controller/kubelet-config/kubelet_config_controller.go
Auto-merging pkg/controller/kubelet-config/helpers.go
Auto-merging cmd/machine-config-operator/start.go
CONFLICT (content): Merge conflict in cmd/machine-config-operator/start.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add cluster fleet evaluation support to mco
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.